Skip to content

IEP-1345: Fix for refreshing the manager after installation #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriiFilippov merged 1 commit into from
Dec 18, 2024
Merged

IEP-1345: Fix for refreshing the manager after installation #1098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/InitializeToolsStartup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
import com.espressif.idf.ui.dialogs.BuildView;
import com.espressif.idf.ui.dialogs.MessageLinkDialog;
import com.espressif.idf.ui.tools.ToolsActivationJob;
import com.espressif.idf.ui.tools.ToolsActivationJobListener;
import com.espressif.idf.ui.tools.manager.pages.ESPIDFMainTablePage;

@SuppressWarnings("restriction")
public class InitializeToolsStartup implements IStartup
Expand Down Expand Up @@ -180,8 +182,9 @@ else if (isInstallerConfigSet())
Logger.log(e);
}
ToolsActivationJob toolsActivationJob = new ToolsActivationJob(newToolSet, pythonExecutablePath, gitExecutablePath);
ToolsActivationJobListener toolsActivationJobListener = new ToolsActivationJobListener(ESPIDFMainTablePage.getInstance());
toolsActivationJob.addJobChangeListener(toolsActivationJobListener);
toolsActivationJob.schedule();

}

// save state
Expand Down
2 changes: 1 addition & 1 deletion bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/tools/manager/ESPIDFManagerEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public boolean isSaveAsAllowed()
@Override
public void createPartControl(Composite parent)
{
ESPIDFMainTablePage espidfMainTablePage = new ESPIDFMainTablePage();
ESPIDFMainTablePage espidfMainTablePage = ESPIDFMainTablePage.getInstance();
espidfMainTablePage.createPage(parent);
}

Expand Down
18 changes: 18 additions & 0 deletions ...om.espressif.idf.ui/src/com/espressif/idf/ui/tools/manager/pages/ESPIDFMainTablePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,22 @@ public class ESPIDFMainTablePage
private static final String RELOAD_ICON = "icons/tools/reload.png"; //$NON-NLS-1$
private static final String IDF_TOOL_SET_BTN_KEY = "IDFToolSet"; //$NON-NLS-1$

private static ESPIDFMainTablePage espidfMainTablePage;

private ESPIDFMainTablePage()
{
}

public static ESPIDFMainTablePage getInstance()
{
if (espidfMainTablePage == null)
{
espidfMainTablePage = new ESPIDFMainTablePage();
}

return espidfMainTablePage;
}

public Composite createPage(Composite composite)
{
toolSetConfigurationManager = new ToolSetConfigurationManager();
Expand All @@ -81,6 +97,8 @@ public Composite createPage(Composite composite)

public void refreshEditorUI()
{
if (container == null)
return;
for (TableItem item : tableViewer.getTable().getItems())
{
String EDITOR_KEY = "action_editor";
Expand Down