procmacros: Replace then_some#132
Merged
Merged
Conversation
which was just [recently stabilized in rust 1.62.0][1] and hence raises the MSRV to 1.62.0 for all HALs. Use `bool::then` instead, which takes a closure instead of a parameter but has the same effect otherwise and is available [since rust 1.50.0][2]. [1]: rust-lang/rust#96628 [2]: https://doc.rust-lang.org/stable/std/primitive.bool.html#method.then
jessebraham
approved these changes
Aug 3, 2022
jessebraham
left a comment
jessebraham
left a comment
Member
There was a problem hiding this comment.
Good catch, thank you! I guess we're not actually verifying MSRV in CI, so I'm working on adding that now as well to avoid this in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which was just recently stabilized in rust 1.62.0 and hence raises
the MSRV to 1.62.0 for all HALs. Use
bool::theninstead, which takes aclosure instead of a parameter but has the same effect otherwise and is
available since rust 1.50.0.
Fixes #131