Skip to content

UTF-8 encoding fix of author tags in src files ready for Erlang 17 - #44

Closed
sebmaynard wants to merge 4 commits into
esl:masterfrom
sebmaynard:master
Closed

UTF-8 encoding fix of author tags in src files ready for Erlang 17#44
sebmaynard wants to merge 4 commits into
esl:masterfrom
sebmaynard:master

Conversation

@sebmaynard

Copy link
Copy Markdown

No description provided.

@jlouis

jlouis commented Apr 9, 2014

Copy link
Copy Markdown

Looks like the build is failing on Travis-CI for some completely different reason. This probably need some help.

I would recommend you change the names for something in the ASCII alphabet though, since it would compile cleanly on all the different releases for which this runs. Otherwise you run into trouble with the older releases as well.

@sebmaynard

Copy link
Copy Markdown
Author

I don't think I can bring myself to do that; it's Oscar's name! I'd be pissed if someone mis-spelt my name...

@ghost

ghost commented Apr 13, 2014

Copy link
Copy Markdown

Lets see. Do I get this correctly.

In R17 OTP have changed from ISO8859-1 to UTF-8 as coding for source files,
including comments and function names and ... Right?

So, now we cannot write Erlang programs (that uses non ascii things) that can compile in both
R17 and earlier. Right?

Please, tell me I am wrong!

/Roland

----- Ursprungligt meddelande -----

Från: "Seb" notifications@github.com
Till: "esl/lhttpc" lhttpc@noreply.github.com
Skickat: onsdag, 9 apr 2014 17:39:51
Ämne: Re: [lhttpc] UTF-8 encoding fix of author tags in src files ready for
Erlang 17 (#44)

I don't think I can bring myself to do that; it's Oscar's name! I'd be pissed
if someone mis-spelt my name...


Reply to this email directly or view it on GitHub .

@eproxus

eproxus commented Apr 14, 2014

Copy link
Copy Markdown

@roland-karlsson-erlang-solutions-com You can, just include the relevant comment in the top of the file. For example: %% -*- coding: utf-8 -*-.

@sebmaynard I assume the most backwards compatible fix for lhttpc in this case is to add a latin1 comment to all the source files (I assume it is %% -*- coding: latin1 -*- but the documentation is a bit unclear on this one).

See http://www.erlang.org/doc/apps/stdlib/unicode_usage.html

@jlouis

jlouis commented Apr 14, 2014

Copy link
Copy Markdown

R16B understands utf-8 encoding as well with that line. So if you don't care about R15 and older, you could just enable the utf-8 encoding and be done with it. The question is for how long you want to support older code. The alternative is to use latin-1 encoding, which is both forwards and backwards compatible.

g-andrade pushed a commit to g-andrade/lhttpc that referenced this pull request Nov 26, 2014
Retry SimpleDB 503s, honor NextToken when present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants