Skip to content

Enable nontrapping-fp by default#23007

Merged
dschuff merged 13 commits into
emscripten-core:mainfrom
dschuff:nontrapping-enable
Dec 19, 2024
Merged

Enable nontrapping-fp by default#23007
dschuff merged 13 commits into
emscripten-core:mainfrom
dschuff:nontrapping-enable

Conversation

@dschuff

@dschuff dschuff commented Nov 25, 2024

Copy link
Copy Markdown
Member

Enable nontrapping-fptoint by lowering the browser target requirement.
Once all 3 Safari 15 features have been enabled, I will reset
the requirement correctly.

@dschuff dschuff changed the title [WIP] Enable nontrapping-fp by default Enable nontrapping-fp by default Nov 28, 2024
@dschuff dschuff marked this pull request as ready for review November 28, 2024 00:43
@dschuff

dschuff commented Nov 28, 2024

Copy link
Copy Markdown
Member Author

Tests are passing; will wait to merge until all 3 are ready.

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I love seeing the code size savings.

@dschuff dschuff enabled auto-merge (squash) December 19, 2024 17:50
@dschuff dschuff merged commit d23a20d into emscripten-core:main Dec 19, 2024
@sbc100

sbc100 commented Dec 19, 2024

Copy link
Copy Markdown
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants