This repository was archived by the owner on Nov 23, 2024. It is now read-only.
Use dep.exists() to check for presence. - #215
Merged
Merged
Conversation
Due to sync issues from greenkeeper PR's, this updates yarn.lock to match current package.json.
Turbo87
reviewed
Oct 8, 2017
| if (checker.for('ember-cli-qunit', 'npm').exists('*')) { | ||
| this._testGenerator = 'qunit'; | ||
| } else if (checker.for('ember-cli-mocha', 'npm').satisfies('*')) { | ||
| } else if (checker.for('ember-cli-mocha', 'npm').exists('*')) { |
Member
There was a problem hiding this comment.
the '*' is not needed anymore, right?
`semver`'s `satisfies` has somewhat bizarre issues around matching prerelease versions. In this case, we don't _really_ care what version you are using at all, we just want to check if you have a given dependency installed. This updates to using a new API in ember-cli-version-checker to simply check if a given dep exists or not.
rwjblue
force-pushed
the
update-detection
branch
from
October 8, 2017 12:40
b7f102d to
773fe4f
Compare
Turbo87
approved these changes
Oct 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semver'ssatisfieshas somewhat bizarre issues around matching prerelease versions. In this case, we don't really care what version you are using at all, we just want to check if you have a given dependency installed.This updates to using a new API in ember-cli-version-checker to simply check if a given dep exists or not.
Fixes #214