Concurrently crawling - #834
Merged
Merged
Conversation
john-shaffer
force-pushed
the
concurrently-crawling
branch
from
November 6, 2021 00:53
0a9f8a9 to
1d5ffe1
Compare
Number of concurrent crawls is set via `apply_filters( 'wp2static_crawl_concurrency', 1 )`
john-shaffer
force-pushed
the
concurrently-crawling
branch
from
November 6, 2021 01:29
1d5ffe1 to
27c7782
Compare
Contributor
|
Excellent work! I resolved the issues you mentioned and added a crawlConcurrency option on the advanced options page. I changed the filter name to On some very small VMs (t3a.micro), I'm seeing improvements from ~10.5s to ~7.5s on a small site with crawlConcurrency=64, and from ~8m to ~6m on a larger slow site with crawlConcurrency=8. Higher concurrency values are slightly slower, but not by much. |
Contributor
Author
|
This is really an amazing improvement. So it looks like this 25-30% is a
quite repeatable thing.
sob., 6 lis 2021, 02:46 użytkownik John Shaffer ***@***.***>
napisał:
… Excellent work!
I resolved the issues you mentioned and added a crawlConcurrency option on
the advanced options page. I changed the filter name to
wp2static_crawl_concurrency.
On some very small VMs (t3a.micro), I'm seeing improvements from ~10.5s to
~7.5s on a small site with crawlConcurrency=64, and from ~8m to ~6m on a
larger slow site with crawlConcurrency=8.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#834 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR34OQVIV46WFQXG3AQF5TUKSJJVANCNFSM5HJQN7DQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation of the discussion #762
It would be great if you could take a second look.
There are some things I'm having problems with:
crawlURL()method is no longer used - so we should either remove it or deprecateCurrently the concurrency rate can be set with
apply_filters( 'wp2static_concurrent_crawl_rate', 1 )and is set to 1 as default.I'm using the new crawler on production for WordPressowka.pl and wpowls.co.