Pagination Detecting Incorrectly

[petewilcock]

Just noticed this:

For post pagination, live site is using siteurl.com/page/1 but isn't being detected.

What it is detecting though is siteurl.com/blog/page/1 which doesn't exist and 404s on crawl.

[petewilcock]

On inspection it looks like this well-meaning PR from @john-shaffer introduced an assumption of post pagination pages being prefixed with /blog:

https://github.com/leonstafford/wp2static/pull/574/files

Manually removed this and recompiled, which fixes the issue for my case.

[john-shaffer]

Apparently some sites have posts paginated under /blog/, while in others it's under /. I can't find any useful documentation about how to determine the prefix.

[leonstafford]

That should be sorted in https://github.com/leonstafford/static-html-output/ it's a bit of a multi-step query with some extra logic thrown in to cover the pagination_base or such.

[leonstafford]

Looking at this code again today while doing some test tidy up and it does stand out as weird to have the /blog/ hardcoded, so will see if I can fix it up

[leonstafford]

get_post_type_archive_link is probably the missing piece within DetectPostsPaginationURLs which I'll add in to check while building those URLs.

[leonstafford]

last commit didn't quite hit it:

/http:/localhost:4683page/1/

should have it sorted soon, now that I'm doing some testing within real site

[leonstafford]

To simulate the custom "Blog" or other name, that you encountered @john-shaffer, I reproduced, by creating 2 x new Pages, "Homepage" and "Blog". I then set these to Homepage and Posts page, respectively in Settings > Reading.

Then, we see the correct URL detected, in this case: /blog/page/1/.

I just need to fix the bad URL shown above, which is when get_post_type_archive_link() returns false (or maybe when it returns just the site url, I need another test for both of these conditions).

[leonstafford]

Now looking better (missed a trailingslashit()).

Without a Posts page set in WP Settings, detects:

/page/1/

With Posts page set to /blog/, we get: /blog/page/1/

[leonstafford]

ugh, taking my time with this one :P

was misunderstanding what I'm getting back from that fn. may opt for the one which gives either the posts url or false, as demo'd here in wp_cli's shell:

# With "sample-page" set as posts page:

wp> get_permalink( get_option( 'page_for_posts' ) )
=> string(34) "http://localhost:4683/sample-page/"

# I reset it back to no Posts page:

wp> 
/usr/html # wp shell
wp> get_permalink( get_option( 'page_for_posts' ) )
=> bool(false)
wp> get_post_type_archive_link( 'post' );
=> string(21) "http://localhost:4683"
wp> 

[john-shaffer]

Both work fine for me, but I would suggest get_post_type_archive_link because it uses the post_type_archive_link filter.

[leonstafford]

Sweet, will try combining the two, as I like the false response from the get_option() call when not set, then use the get_post_type_archive_link for most accurate URL

[leonstafford]

(without the get_permalink, the get_option() call will return "0", which is still enough to test the condition)