fix: add std=c++17 flag for e20+

[VerteDinde]

Addresses e/e issue 34209 while 20.0.0-beta.1 is in beta.

This PR adds a compile flag for -std=c++17 when using Electron 20 or higher.

[malept]

Is this a chore: or a fix:?

[malept]

Might be worth adding a test if we have unit tests for clang-fetcher?

[codecov-commenter]

Codecov Report

Merging #1022 (979361d) into master (20107a8) will decrease coverage by 0.37%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   76.38%   76.01%   -0.38%     
==========================================
  Files          19       19              
  Lines         686      692       +6     
  Branches      131      133       +2     
==========================================
+ Hits          524      526       +2     
- Misses        118      120       +2     
- Partials       44       46       +2     

Impacted Files	Coverage Δ
src/module-type/node-gyp.ts	82.50% <0.00%> (-2.12%)	⬇️
src/clang-fetcher.ts	79.72% <50.00%> (-1.70%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20107a8...979361d. Read the comment docs.

[VerteDinde]

@malept Looks like we don't have any unit tests for clang-fetcher - I'll see if I can add some

[ckerr]

This is good for now and solves a real problem.

For electron/electron I'm working on some solution that would provide the build flags that come from upstream so that we don't have to hardcode a particular version. However in practice this is only going to change every few years (any predictions on when Chromium will jump to C++20?)

Also, upstream hardcodes this in several places too, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/3306812 for one example.

👍 on tests but since there weren't any before, I wouldn't block on it

[electron-bot]

🎉 This PR is included in version 3.2.9 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀