Remove Confluent dependencies and in-source schema classes (Jackson 3 migration phases 1-7)#253
Conversation
…registry.json.diff.SchemaDiff
…a.schemaregistry.json.JsonSchema
…se in-sourced schema classes Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
|
@copilot the tests are not compiling, make sure you run all tests and that they compile and complete successfully |
Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
Fixed in bce923f. Three issues found and resolved:
All 130+ tests across all modules compile and pass. |
| * {@link Schema} used for validation. | ||
| */ | ||
| public final class JsonSchema { | ||
| private static final ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
create an optional constructor where the ObjectMapper can be injected. If the default constructor is used use the static mapper
There was a problem hiding this comment.
Added in 54f276c. The ObjectMapper is now an instance field. Default constructors delegate to new three-arg constructors (String, Integer, ObjectMapper and JsonNode, Integer, ObjectMapper) passing DEFAULT_OBJECT_MAPPER. The toJson() and toString() methods use the injected instance.
…tors use static mapper Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
main/sharedorg.elasticsoftware.akces.schemas.diff.Differencerecord with all Type enum valuesorg.elasticsoftware.akces.schemas.diff.SchemaDiffwithcompare()andCOMPATIBLE_CHANGES_STRICTorg.elasticsoftware.akces.schemas.JsonSchemawrapper class with optionalObjectMapperinjection (default constructors use a static mapper)everit-json-schemaas explicit dependency in shared pom.xml✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.