Fix victools v5.0.0 compilation: adapt to Jackson 3 internal migration#244
Merged
jwijgerd merged 3 commits intoMar 15, 2026
Conversation
…ion) - Update SchemaRegistry to use Jackson 3 API: remove ObjectMapper parameter, use SchemaVersion/OptionPreset constructor, Jackson 3 types in callbacks - Replace deprecated JacksonModule with JacksonSchemaModule - Convert generateSchema() output to String for JsonSchema construction - Update KafkaSchemaRegistry constructor (remove unused ObjectMapper param) - Update all callers and test files Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
…Node instead of fully-qualified name Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compilation issues from upgrading victools to v5.0.0
Fix victools v5.0.0 compilation: adapt to Jackson 3 internal migration
Mar 14, 2026
jwijgerd
marked this pull request as ready for review
March 15, 2026 14:21
jwijgerd
approved these changes
Mar 15, 2026
jwijgerd
merged commit Mar 15, 2026
5170a66
into
dependabot/maven/victools.version-5.0.0
1 check passed
jwijgerd
added a commit
that referenced
this pull request
Mar 15, 2026
* build(deps): bump victools.version from 4.38.0 to 5.0.0 Bumps `victools.version` from 4.38.0 to 5.0.0. Updates `com.github.victools:jsonschema-generator` from 4.38.0 to 5.0.0 - [Release notes](https://github.com/victools/jsonschema-generator/releases) - [Changelog](https://github.com/victools/jsonschema-generator/blob/main/CHANGELOG.md) - [Commits](victools/jsonschema-generator@v4.38.0...v5.0.0) Updates `com.github.victools:jsonschema-module-jakarta-validation` from 4.38.0 to 5.0.0 - [Release notes](https://github.com/victools/jsonschema-generator/releases) - [Changelog](https://github.com/victools/jsonschema-generator/blob/main/CHANGELOG.md) - [Commits](victools/jsonschema-generator@v4.38.0...v5.0.0) Updates `com.github.victools:jsonschema-module-jackson` from 4.38.0 to 5.0.0 - [Release notes](https://github.com/victools/jsonschema-generator/releases) - [Changelog](https://github.com/victools/jsonschema-generator/blob/main/CHANGELOG.md) - [Commits](victools/jsonschema-generator@v4.38.0...v5.0.0) --- updated-dependencies: - dependency-name: com.github.victools:jsonschema-generator dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: com.github.victools:jsonschema-module-jakarta-validation dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: com.github.victools:jsonschema-module-jackson dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Fix victools v5.0.0 compilation: adapt to Jackson 3 internal migration (#244) * Initial plan * Fix compilation issues from victools v5.0.0 upgrade (Jackson 3 migration) - Update SchemaRegistry to use Jackson 3 API: remove ObjectMapper parameter, use SchemaVersion/OptionPreset constructor, Jackson 3 types in callbacks - Replace deprecated JacksonModule with JacksonSchemaModule - Convert generateSchema() output to String for JsonSchema construction - Update KafkaSchemaRegistry constructor (remove unused ObjectMapper param) - Update all callers and test files Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com> * Address code review: use import for tools.jackson.databind.node.ArrayNode instead of fully-qualified name Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joost van de Wijgerd <jwijgerd@gmail.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
victools
jsonschema-generatorv5.0.0 migrated its internals from Jackson 2 (com.fasterxml.jackson.*) to Jackson 3 (tools.jackson.*), breaking compilation at the boundary where victools output feeds into Confluent'sJsonSchema(which still uses Jackson 2).Core changes
SchemaRegistry.createJsonSchemaGenerator()— RemovedObjectMapperparameter since victools now uses its own Jackson 3 ObjectMapper internally. Use the(SchemaVersion, OptionPreset)constructor instead. ConvertgenerateSchema()output toStringbefore passing to Confluent'sJsonSchema:TypeAttributeOverridecallback — Switched to Jackson 3ArrayNodeimport for the BigDecimal type overrideJacksonModule→JacksonSchemaModule— Replaced deprecated class across all usagesKafkaSchemaRegistry— Removed now-unusedObjectMapperconstructor parameter; updated all 6 call sitescreateJsonSchemaGenerator()calls📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.