Nest wallet endpoints under account resource#178
Merged
Conversation
Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update wallet API endpoints to use account-specific path
Nest wallet endpoints under account resource
Nov 16, 2025
jwijgerd
marked this pull request as ready for review
November 16, 2025 21:04
Contributor
|
@copilot also update the CryptoTradingE2ETests |
Co-authored-by: jwijgerd <914840+jwijgerd@users.noreply.github.com>
Contributor
Author
Updated CryptoTradingE2ETests with the new account-scoped wallet endpoints in commit 1b95aca. All three wallet endpoint URIs have been changed:
|
jwijgerd
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Update Wallet API Endpoints to Use Account-Scoped Paths ✅ COMPLETE
Current State
/v1/wallets/{walletId}/.../v1/accounts/{accountId}/...Changes Required
/v1/accounts/{accountId}/walletpath/v1/wallets/{walletId}/balances/{currency}/creditto/v1/accounts/{accountId}/wallet/balances/{currency}/credit/v1/wallets/{walletId}/balancesto/v1/accounts/{accountId}/wallet/balances/v1/accounts/{accountId}/walletpath/v1/wallets/{walletId}to/v1/accounts/{accountId}/walletTest Results
✅ Code compiles successfully
✅ testCreateAccount - PASSED
✅ testCreateAccountAndCreditWallet - PASSED
✅ testCreateAccountAndAddBtcBalance - PASSED
✅ testCreateAccountAndCreditWalletWithoutBalance - PASSED
Summary
All changes have been successfully implemented and verified. The wallet API endpoints now use account-scoped paths (
/v1/accounts/{accountId}/wallet/...) instead of separate wallet paths (/v1/wallets/{walletId}/...). This better reflects the domain model where each account has exactly one wallet.Files Changed (5 files)
WalletCommandController.java- Updated paths and renamed path variableWalletQueryController.java- Updated paths and renamed path variableCryptoTradingCommandApiTest.java- Updated test URIsCryptoTradingQueryApiTest.java- Updated test URIsCryptoTradingE2ETests.java- Updated E2E test URIsNote: Only REST API layer changed; no modifications to Aggregates, Commands, Events, or domain logic.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.