Skip to content

[kolide, f5_bigip, cisco_umbrella] Add Terraform resource labels - #20707

Open
mrodm wants to merge 4 commits into
elastic:mainfrom
mrodm:update_terraform_labels_batch4
Open

[kolide, f5_bigip, cisco_umbrella] Add Terraform resource labels#20707
mrodm wants to merge 4 commits into
elastic:mainfrom
mrodm:update_terraform_labels_batch4

Conversation

@mrodm

@mrodm mrodm commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Proposed commit message

[kolide, f5_bigip, cisco_umbrella, aws_bedrock] Add Terraform resource labels

Add four standard resource labels to the AWS provider `default_tags`
block in all Terraform `main.tf` files for the following packages:

- kolide (5 data streams: audit, auth, device_check, osquery_result, osquery_status)
- f5_bigip (1 file)
- cisco_umbrella (1 file)

Labels added to each file:

  division = "engineering"
  org      = "obs"
  team     = "<team derived from owner.github in manifest.yml>"
  project  = "integrations-<package_name>-package"

The `team` value is derived from the `owner.github` field in each
package's `manifest.yml`, and `project` follows the pattern
`integrations-<package_name>-package` using the `name` field.

Author's Checklist

  • All 7 main.tf files updated with the correct team and project values derived from their respective manifest.yml

This PR was generated with the assistance of Claude (claude-sonnet-4-6).

Add four standard resource labels to the AWS provider `default_tags`
block in all Terraform `main.tf` files for the following packages:

- kolide (5 data streams: audit, auth, device_check, osquery_result, osquery_status)
- f5_bigip (1 file)
- cisco_umbrella (1 file)

Labels added to each file:

  division = "engineering"
  org      = "obs"
  team     = "integration-experience"
  project  = "integrations-<package_name>-package"

The `team` value is derived from the `owner.github` field in each
package's `manifest.yml`, and `project` follows the pattern
`integrations-<package_name>-package` using the `name` field.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mrodm mrodm self-assigned this Aug 13, 2026
mrodm and others added 3 commits August 13, 2026 17:39
Add four standard resource labels to the AWS provider `default_tags`
block in the Terraform `main.tf` file for aws_bedrock (invocation
data stream).

Labels added:

  division = "engineering"
  org      = "obs"
  team     = "security-service-integrations"
  project  = "integrations-aws_bedrock-package"

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add inline comments to the team and project labels clarifying their
source in the package manifest.yml:

  team    # owner.github in manifest.yml
  project # name in manifest.yml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

cc @mrodm

@mrodm
mrodm requested a review from a team August 14, 2026 07:14
@mrodm
mrodm marked this pull request as ready for review August 14, 2026 07:14
Copilot AI lite review requested due to automatic review settings August 14, 2026 07:14
@mrodm
mrodm requested a review from a team as a code owner August 14, 2026 07:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a set of standardized AWS Terraform default_tags labels (division, org, team, project) to integration package _dev/deploy/tf/main.tf files so test/deploy resources get consistent metadata tagging across packages.

Changes:

  • Added division = "engineering" and org = "obs" tags to the affected Terraform default_tags.
  • Added team (derived from owner.github in each package’s manifest.yml) and project (derived from name in manifest.yml) tags.
  • Updated Terraform files for Kolide (5 data streams), F5 BIG-IP, and Cisco Umbrella (note: PR description also mentions aws_bedrock, but that change does not appear to be present in the code).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/kolide/data_stream/audit/_dev/deploy/tf/main.tf Add standard default_tags resource labels.
packages/kolide/data_stream/auth/_dev/deploy/tf/main.tf Add standard default_tags resource labels.
packages/kolide/data_stream/device_check/_dev/deploy/tf/main.tf Add standard default_tags resource labels.
packages/kolide/data_stream/osquery_result/_dev/deploy/tf/main.tf Add standard default_tags resource labels.
packages/kolide/data_stream/osquery_status/_dev/deploy/tf/main.tf Add standard default_tags resource labels.
packages/f5_bigip/_dev/deploy/tf/main.tf Add standard default_tags resource labels.
packages/cisco_umbrella/_dev/deploy/tf/main.tf Add standard default_tags resource labels.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/kolide/data_stream/osquery_status/_dev/deploy/tf/main.tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants