[kolide, f5_bigip, cisco_umbrella] Add Terraform resource labels - #20707
Open
mrodm wants to merge 4 commits into
Open
[kolide, f5_bigip, cisco_umbrella] Add Terraform resource labels#20707mrodm wants to merge 4 commits into
mrodm wants to merge 4 commits into
Conversation
Add four standard resource labels to the AWS provider `default_tags` block in all Terraform `main.tf` files for the following packages: - kolide (5 data streams: audit, auth, device_check, osquery_result, osquery_status) - f5_bigip (1 file) - cisco_umbrella (1 file) Labels added to each file: division = "engineering" org = "obs" team = "integration-experience" project = "integrations-<package_name>-package" The `team` value is derived from the `owner.github` field in each package's `manifest.yml`, and `project` follows the pattern `integrations-<package_name>-package` using the `name` field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add four standard resource labels to the AWS provider `default_tags` block in the Terraform `main.tf` file for aws_bedrock (invocation data stream). Labels added: division = "engineering" org = "obs" team = "security-service-integrations" project = "integrations-aws_bedrock-package" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit e7c955e.
Add inline comments to the team and project labels clarifying their source in the package manifest.yml: team # owner.github in manifest.yml project # name in manifest.yml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @mrodm |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a set of standardized AWS Terraform default_tags labels (division, org, team, project) to integration package _dev/deploy/tf/main.tf files so test/deploy resources get consistent metadata tagging across packages.
Changes:
- Added
division = "engineering"andorg = "obs"tags to the affected Terraformdefault_tags. - Added
team(derived fromowner.githubin each package’smanifest.yml) andproject(derived fromnameinmanifest.yml) tags. - Updated Terraform files for Kolide (5 data streams), F5 BIG-IP, and Cisco Umbrella (note: PR description also mentions aws_bedrock, but that change does not appear to be present in the code).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/kolide/data_stream/audit/_dev/deploy/tf/main.tf | Add standard default_tags resource labels. |
| packages/kolide/data_stream/auth/_dev/deploy/tf/main.tf | Add standard default_tags resource labels. |
| packages/kolide/data_stream/device_check/_dev/deploy/tf/main.tf | Add standard default_tags resource labels. |
| packages/kolide/data_stream/osquery_result/_dev/deploy/tf/main.tf | Add standard default_tags resource labels. |
| packages/kolide/data_stream/osquery_status/_dev/deploy/tf/main.tf | Add standard default_tags resource labels. |
| packages/f5_bigip/_dev/deploy/tf/main.tf | Add standard default_tags resource labels. |
| packages/cisco_umbrella/_dev/deploy/tf/main.tf | Add standard default_tags resource labels. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
teresaromero
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Author's Checklist
main.tffiles updated with the correctteamandprojectvalues derived from their respectivemanifest.yml