Skip to content

[cloudflare_logpush] Add Terraform resource labels - #20705

Open
mrodm wants to merge 2 commits into
elastic:mainfrom
mrodm:update_terraform_labels_batch2
Open

[cloudflare_logpush] Add Terraform resource labels#20705
mrodm wants to merge 2 commits into
elastic:mainfrom
mrodm:update_terraform_labels_batch2

Conversation

@mrodm

@mrodm mrodm commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Proposed commit message

[cloudflare_logpush] Add Terraform resource labels

Add four standard resource labels to the AWS provider `default_tags`
block in all 21 Terraform `main.tf` files for the `cloudflare_logpush`
package:

  division = "engineering"
  org      = "obs"
  team     = "security-service-integrations"
  project  = "integrations-cloudflare_logpush-package"

The `team` value is derived from the `owner.github` field in the
package's `manifest.yml`, and `project` follows the pattern
`integrations-<package_name>-package` using the `name` field.

Author's Checklist

  • All 21 main.tf files updated with the correct team and project values derived from manifest.yml

This PR was generated with the assistance of Claude (claude-sonnet-4-6).

Add four standard resource labels to the AWS provider `default_tags`
block in all 21 Terraform `main.tf` files for the `cloudflare_logpush`
package:

  division = "engineering"
  org      = "obs"
  team     = "security-service-integrations"
  project  = "integrations-cloudflare_logpush-package"

The `team` value is derived from the `owner.github` field in the
package's `manifest.yml`, and `project` follows the pattern
`integrations-<package_name>-package` using the `name` field.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mrodm mrodm self-assigned this Aug 13, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

cc @mrodm

@mrodm
mrodm requested a review from a team August 14, 2026 07:13
@mrodm
mrodm marked this pull request as ready for review August 14, 2026 07:13
@mrodm
mrodm requested a review from a team as a code owner August 14, 2026 07:13
Copilot AI lite review requested due to automatic review settings August 14, 2026 07:13
@mrodm
mrodm requested a review from a team as a code owner August 14, 2026 07:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes AWS resource tagging for the cloudflare_logpush integration’s Terraform dev deployment configs by adding four organization-wide labels to the AWS provider default_tags block, improving cost allocation and asset ownership traceability across all data streams.

Changes:

  • Add division, org, team, and project to provider "aws" { default_tags { tags = { ... }}} across all Cloudflare Logpush data stream Terraform main.tf files.
  • Align team and project values with the package’s manifest.yml ownership/name conventions.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/cloudflare_logpush/data_stream/workers_trace/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/spectrum_event/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/sinkhole_http/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/page_shield_events/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/network_session/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/network_analytics/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/nel_report/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/magic_ids/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/http_request/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/gateway_network/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/gateway_http/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/gateway_dns/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/firewall_event/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/email_security_alerts/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/dns/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/dns_firewall/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/dlp_forensic_copies/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/device_posture/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/casb/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/audit/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.
packages/cloudflare_logpush/data_stream/access_request/_dev/deploy/tf/main.tf Adds standard resource labels to AWS provider default tags.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants