[cloudflare_logpush] Add Terraform resource labels - #20705
Open
mrodm wants to merge 2 commits into
Open
Conversation
Add four standard resource labels to the AWS provider `default_tags` block in all 21 Terraform `main.tf` files for the `cloudflare_logpush` package: division = "engineering" org = "obs" team = "security-service-integrations" project = "integrations-cloudflare_logpush-package" The `team` value is derived from the `owner.github` field in the package's `manifest.yml`, and `project` follows the pattern `integrations-<package_name>-package` using the `name` field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @mrodm |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes AWS resource tagging for the cloudflare_logpush integration’s Terraform dev deployment configs by adding four organization-wide labels to the AWS provider default_tags block, improving cost allocation and asset ownership traceability across all data streams.
Changes:
- Add
division,org,team, andprojecttoprovider "aws" { default_tags { tags = { ... }}}across all Cloudflare Logpush data stream Terraformmain.tffiles. - Align
teamandprojectvalues with the package’smanifest.ymlownership/name conventions.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cloudflare_logpush/data_stream/workers_trace/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/spectrum_event/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/sinkhole_http/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/page_shield_events/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/network_session/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/network_analytics/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/nel_report/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/magic_ids/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/http_request/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/gateway_network/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/gateway_http/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/gateway_dns/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/firewall_event/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/email_security_alerts/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/dns/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/dns_firewall/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/dlp_forensic_copies/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/device_posture/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/casb/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/audit/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
| packages/cloudflare_logpush/data_stream/access_request/_dev/deploy/tf/main.tf | Adds standard resource labels to AWS provider default tags. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
5 tasks
teresaromero
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Author's Checklist
main.tffiles updated with the correctteamandprojectvalues derived frommanifest.yml