Set a single solution category on datastream level for dual-tagged (obs/sec) packages - #20703
Draft
tdancheva wants to merge 3 commits into
Draft
Set a single solution category on datastream level for dual-tagged (obs/sec) packages#20703tdancheva wants to merge 3 commits into
tdancheva wants to merge 3 commits into
Conversation
Contributor
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
✅ All changelog entries have the correct PR link. |
💔 Build Failed
Failed CI StepsHistory
|
Contributor
🚀 Benchmarks reportTo see the full report comment with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
WHAT: For the 18 packages that are dual-tagged
security+observabilityat package level, set a single solution category on each data stream that did not already have one in its datastreammanifest.yml. Package-levelcategoriesstay dual.Pattern follows #19911: keep non-solution categories (
aws,cloud,network, …); write exactly one ofsecurity|observabilityon the datastream; also copy any extra policy-template categories (lint requires the datastream list to be a superset of the template); patch-bump the package; changelogbugfix.Scope: 173 datastreams.
securityand/orobservabilityon the datastream manifest → left unchanged (42 unique observability, 6 dual).Assignment for streams that needed a fill, in order:
owner.github, then package CODEOWNERS.elastic-agent-data-plane→ observability;cloud-services+ Defend for Containers → security;integration-experience+ Falco → security.categoriesmust include every policy-template category. Extra tags are unioned in. If the policy template already has a unique solution category, that wins over CODEOWNERS (cannot drop a policy template solution tag).Left dual on purpose (already had both on the datastream manifest; ownership logic would have collapsed them):
gcp.loadbalancing_logs,gcp.loadbalancing_metrics,aws.transitgateway— logic would pick observability (CODEOWNERS obs-infraobs vs policy-template security; blame Update cloud packages codeowner #8672).gcp.vpcflow— logic would pick security (SSI CODEOWNERS + security policy template).tencent_cloud.clb,tencent_cloud.cos— logic would pick security (package owner SSI; dual policy-template cats).Filled streams where ownership logic disagreed with the policy template, then aligned to the template for lint:
auditlogs/signinlogs/identity_protection/provisioning→ security (templateadlogs; CODEOWNERS would have been observability).aws.vpcflow→ observability (+network) (template; CODEOWNERS SSI would have been security).More details on how the decision was taken on datastream level in comment.
WHY:
This metadata will be used to re-define the Obs and Security marker, i.e. how do we define Obs/Sec customer based on our telemetry.
Dual solution categories at datastream level make security vs observability ownership ambiguous for markers. Same problem #19911 fixed for a subset of GCP/AWS streams. This extends that to the remaining dual-tagged packages, without overwriting an existing datastream-manifest solution category.
Packages (patch bump): o365_metrics, windows, openai, mongodb_atlas, oracle, cloud_defend, microsoft_sqlserver, panw_metrics, sysdig, zoom, aws_bedrock, azure_frontdoor, falco, menlo, gcp, azure, tencent_cloud, aws.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots