Skip to content

feat: set CLIENT SETNAME for server-side connection identification #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atao2004 merged 1 commit into from
Jun 8, 2026
Merged

feat: set CLIENT SETNAME for server-side connection identification #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions runtime/node/agent/memory/valkey_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def _make_client(host: str, port: int, username: str | None = None, password: st
addresses=[glide_sync.NodeAddress(host, port)],
use_tls=use_tls,
credentials=credentials,
client_name="chatdev_memory_client",
database_id=db if db != 0 else None,
)
return glide_sync.GlideClient.create(config)
Expand Down
14 changes: 14 additions & 0 deletions tests/test_valkey_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,20 @@ def test_username_passed_to_make_client(self):
assert call_args[2] == "myuser" # username
assert call_args[3] == "mypass" # password

def test_client_name_set_in_configuration(self):
"""_make_client sets client_name='chatdev_memory_client' for server-side identification."""
from runtime.node.agent.memory.valkey_memory import _make_client

mock_glide_module = MagicMock()

with patch("runtime.node.agent.memory.valkey_memory._get_glide_sync") as mock_get_glide:
mock_get_glide.return_value = mock_glide_module
_make_client("localhost", 6379)

# Verify GlideClientConfiguration was called with client_name
config_call = mock_glide_module.GlideClientConfiguration.call_args
assert config_call[1]["client_name"] == "chatdev_memory_client"


# ---------------------------------------------------------------------------
# Tag sanitization
Expand Down