Skip to content

Adds missing test coverage for fields and logic introduced in PR #3 (…#4

Merged
atao2004 merged 1 commit into
add-valkeyfrom
fix-tests-for-new-fields
Jun 8, 2026
Merged

Adds missing test coverage for fields and logic introduced in PR #3 (…#4
atao2004 merged 1 commit into
add-valkeyfrom
fix-tests-for-new-fields

Conversation

@atao2004

@atao2004 atao2004 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds missing test coverage for fields and logic introduced in PR #3 (ValkeyMemory implementation).

Changes

  • tests/test_valkey_memory.py
    • Config tests now assert username and use_tls parsing (both defaults and explicit values)
    • test_field_specs_defined includes the new fields
    • New TestValkeyMemoryConnectionOptions — verifies use_tls and username are forwarded to _make_client
    • New TestValkeyMemorySanitizeTag — 6 tests covering _sanitize_tag() (commas, braces, spaces, pipes, empty, clean input)
    • Test helpers (_make_store, _make_valkey_memory) updated to support username, password, and use_tls params

Testing

  • 55 tests pass (up from 47), 0 failures
  • Full suite: 109 passed, 0 regressions

@edlng edlng left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

@atao2004 atao2004 merged commit b510d70 into add-valkey Jun 8, 2026
@atao2004 atao2004 deleted the fix-tests-for-new-fields branch June 8, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants