Fix phpstan: ignore env-dependent PHP_CodeSniffer token constant error#41
Merged
Conversation
…ution NewlineAnalyzer uses T_OPEN_CURLY_BRACKET, a PHP_CodeSniffer constant whose value differs by env (undefined -> "Constant not found", or the string 'PHPCS_T_OPEN_CURLY_BRACKET' leaking into an int-kind array). Scope the ignore to both variants with reportUnmatched: false so whichever the env produces is silenced without code changes.
TomasVotruba
force-pushed
the
fix-phpstan-token-constant
branch
from
efc61b0 to
2df2bf5
Compare
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewlineAnalyzerpassesT_OPEN_CURLY_BRACKETto php-cs-fixer'sToken::isGivenKind(). That constant is defined by PHP_CodeSniffer, and its resolution differs per environment:Constant T_OPEN_CURLY_BRACKET not found'PHPCS_T_OPEN_CURLY_BRACKET'→ it leaks into theintkind array, giving anargument.typeerror (isGivenKind()expectsint|list<int>)No code change. Just scope the phpstan ignores to both variants with
reportUnmatched: false, so whichever error the running environment produces is silenced and the other does not complain about being unmatched.phpstan green, rector + ecs clean, all tests pass.