Eliminate String intermediaries in JSON codecs - #1685
Open
tsegismont wants to merge 1 commit into
Open
Conversation
Encode and decode JSON directly between ByteBuf and Jackson, avoiding unnecessary charset conversions through String objects. Note that the PG size estimator now uses a fixed 256-byte estimate for non-String JSON values (JsonObject, JsonArray, etc.) since computing the exact size would require serializing the JSON twice. Resizing shouldn't cost too much with the adaptive ByteBuf allocator. Assisted-by: Claude Opus 4.6 Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode and decode JSON directly between
ByteBufand Jackson, avoiding unnecessary charset conversions throughStringobjects.Note that the PG size estimator now uses a fixed 256-byte estimate for non-
StringJSON values (JsonObject,JsonArray, etc.) since computing the exact size would require serializing the JSON twice. Resizing shouldn't cost too much with the adaptiveByteBufallocator.