Add support for parsing ASN.1 GeneralizedTime in X509 Certificates - #267
Merged
fdesbiens merged 9 commits intoMay 28, 2026
Merged
Conversation
Contributor
Author
|
Need to update tests |
sjscymru
force-pushed
the
support-asn1-generalized-time
branch
from
March 24, 2025 09:50
99ac1a0 to
3c349b7
Compare
Contributor
|
@eclipse-threadx/iot-threadx-committers: please review. |
Resolve the X.509 GeneralizedTime conflict, remove the unused fractional variable, and add bounds checks for ASN.1 time parsing.
Contributor
|
@sjscymru Our apologies for the long turnaround on this PR. I fixed some issues with the implementation. I am ready to merge this into the dev branch, and the code should ship with our June 2026 release. Your feedback is welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes implement support for parsing of ASN.1 GeneralizedTime strings contained in X509 certificates.
Support has also been added to allow the
notBeforeandnotAftertime formats to be different. The current released version of NetX Secure assumed that both time formats would be the same.