New shots for Solo#416
Merged
Merged
Conversation
| } | ||
|
|
||
| SoloPanoOptions(ByteBuffer buffer) { | ||
| this(buffer.get(), buffer.get() == PANO_ON_VALUE, (short) buffer.getShort(), buffer.getFloat(), buffer.getFloat()); |
Member
There was a problem hiding this comment.
@phmagic the first parameter is an int, so buffer.getInt() should be used instead.
buffer.getShort() doesn't need a cast as well.
Member
There was a problem hiding this comment.
@phmagic nevermind, I see below you're storing the panoPreference as a byte.
Member
|
@phmagic In addition, can you add a javadoc on top of the new |
- Pano and Rewind options: restrict input of preference parameters - SoloZiplineLock - removed necessary code - build.gradle - revert back to 1.5.0
- Made PanoOptions a subclass of TLVPacket since it does not use anything from the previous parent (SoloShotOptions) - changed PanoStatus variables to byte instead of int
Member
|
@phmagic looks good to go. I'll merge this pr in, feel free to open another one with the updated javadocs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zipline Message
Pano Messages
Rewind Options Message
Return to Me Message