Update Source-Build SDK Diff Tests Baselines and Exclusions#41716
Merged
Conversation
…ld/results?buildId=2479075 (internal Microsoft link)
3 tasks
Comment on lines
+597
to
+598
| +./sdk/x.y.z/Roslyn/bincore/System.Collections.Immutable.dll | ||
| +./sdk/x.y.z/Roslyn/bincore/System.Reflection.Metadata.dll |
Member
There was a problem hiding this comment.
Will readd exclusion and resolve with dotnet/source-build#4016
mthalman
approved these changes
Jun 21, 2024
ellahathaway
enabled auto-merge (squash)
June 21, 2024 20:08
This was referenced Jun 21, 2024
Open
ellahathaway
disabled auto-merge
June 24, 2024 16:48
ellahathaway
force-pushed
the
pr-baseline-20240621110933
branch
from
June 24, 2024 16:51
5507f54 to
d5f7fdb
Compare
ellahathaway
force-pushed
the
pr-baseline-20240621110933
branch
from
June 27, 2024 15:33
056e1c1 to
6b089f4
Compare
ellahathaway
enabled auto-merge (squash)
June 27, 2024 15:33
ellahathaway
disabled auto-merge
July 1, 2024 16:26
Member
|
I can't get this PR merged until the checks begin passing (the failures are unrelated to the changes in this PR). Since the PR tool keeps overriding my changes, I'm not going to update this PR again until we know that CI checks will pass. |
Member
|
Will check in on CI in the morning once this PR gets updated (again) by the PR creator tool. At that point, I'll figure out the associated issue to link to if the CI is still failing, update this PR accordingly, and ping someone one the source-build team to get this merged on red since so far the CI failures have been unrelated. |
3 tasks
ellahathaway
force-pushed
the
pr-baseline-20240621110933
branch
from
July 2, 2024 16:16
e8c967f to
d5f7fdb
Compare
ellahathaway
enabled auto-merge (squash)
July 2, 2024 16:17
Member
|
CI failure is unrelated. @MichaelSimons - could you merge this for me please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the
CreateBaselineUpdatePRtool for build 2486711.The updated test results can be found at https://dev.azure.com/dnceng/internal/_build/results?buildId=2486711 (internal Microsoft link)