LogicalName added for EmbeddedResource

[rzsc]

The test is trying to get a manifest named "test22888resources.test22888.resources" but according to the rule from https://learn.microsoft.com/en-us/dotnet/core/resources/manifest-file-names:

"If the resource file is colocated with a source file (.cs or .vb) of the same root file name, the full name of the first type that's defined in the source file is used for the manifest file name."

The resource file "test22888.resx" colocated with a C# source file "test22888.cs" so the manifest gets name after the first type defined in the C# source file (TestAssemblyLoadContext.resources).

Here is the next paragraph from the aforementioned web page:

"If a resource file is explicitly included in the project file as an EmbeddedResource item with LogicalName metadata, the LogicalName value is used as the manifest name. LogicalName takes precedence over any other metadata or setting."

To solve the problem LogicalName="test22888resources.test22888.resources" attribute has been added to EmbeddedResource item in "test22888resources.csproj" project file to make the manifest name to be as the test expects it.

The test has been removed from the tests exclusion file "./src/tests/issues.targets".

Part of #84834, cc @dotnet/samsung

Fixes #13703

[jkotas]

Test introduced by dotnet/coreclr#22925

[clamp03]

Related Issue: #13703

[jkotas]

The re-enabled test is failing on Mono:

/tmp/helix/working/A93108F6/p/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true test22888.dll ''
Failed to unload the test assembly
Xunit.Sdk.EqualException: Assert.Equal() Failure: Values differ
Expected: 100
Actual:   101
   at Xunit.Assert.Equal[Int32](Int32 expected, Int32 actual, IEqualityComparer`1 comparer) in /_/src/Microsoft.DotNet.XUnitAssert/src/EqualityAsserts.cs:line 168
   at Xunit.Assert.Equal[Int32](Int32 expected, Int32 actual) in /_/src/Microsoft.DotNet.XUnitAssert/src/EqualityAsserts.cs:line 90
   at __GeneratedMainWrapper.Main()

Mono does not support collectible assemblies that this test is exercising. Could you please keep the test disabled on Mono against #34072 ? (Look for this issue number in issues.targets to find the right place where it should be disabled.

[rzsc]

Mono does not support collectible assemblies that this test is exercising. Could you please keep the test disabled on Mono against #34072 ? (Look for this issue number in issues.targets to find the right place where it should be disabled.

Understood. I'm on it. Thanks!

[jkotas]

Is this ready for review?

[clamp03]

Is this ready for review?

@jkotas I think it is ready for review. Could you review it? Thank you.

[rzsc]

Is this ready for review?

@jkotas sorry for delayed reply. The PR is ready for review. Thanks!

[jkotas]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[rzsc]

@jkotas, I can see that some checks were not successful...
Are these failures related to my changes?
I cannot deduce it from error messages...
I can see some warnings related to the test22888, the one I have modified and enabled. Shall I fix these warnings?
Thank you for all your help!

[jkotas]

/azp run runtime-nativeaot-outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

Thanks