Skip to content

JIT: remove size contribution to perf score #97069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyAyersMS merged 5 commits into from
Jan 19, 2024
Merged

JIT: remove size contribution to perf score #97069

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae7a3f6
JIT: remove size contribution to perf score
AndyAyersMS Jan 17, 2024
01969ac
Merge branch 'main' into ThereIsNoSizeInPerfScore
AndyAyersMS Jan 17, 2024
f8e5c88
review feedback
AndyAyersMS Jan 18, 2024
57db2c4
Merge remote-tracking branch 'upstream/main' into ThereIsNoSizeInPerf…
AndyAyersMS Jan 18, 2024
2b79520
Merge remote-tracking branch 'origin/ThereIsNoSizeInPerfScore' into T…
AndyAyersMS Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/coreclr/jit/codegencommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2002,14 +2002,6 @@ void CodeGen::genEmitMachineCode()
compiler->compCodeGenDone = true;
#endif

#if defined(DEBUG) || defined(LATE_DISASM)
// Add code size information into the Perf Score
// All compPerfScore calculations must be performed using doubles
compiler->info.compPerfScore += ((double)compiler->info.compTotalHotCodeSize * (double)PERFSCORE_CODESIZE_COST_HOT);
compiler->info.compPerfScore +=
((double)compiler->info.compTotalColdCodeSize * (double)PERFSCORE_CODESIZE_COST_COLD);
Comment on lines -2008 to -2010

@BruceForstall BruceForstall Jan 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove the definitions of PERFSCORE_CODESIZE_COST_HOT / PERFSCORE_CODESIZE_COST_COLD, which will be no longer used.

@AndyAyersMS AndyAyersMS Jan 18, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done.

#endif // DEBUG || LATE_DISASM

if (compiler->opts.disAsm && compiler->opts.disTesting)
{
printf("; END METHOD %s\n", compiler->eeGetMethodFullName(compiler->info.compMethodHnd));
Expand Down