Add trim analysis warnings for delegate creation#92427
Merged
Merged
Conversation
The ILLink analyzer was not producing warnings for annotated methods, lambdas, or local functions accessed for delegate creation. Some ExpectedWarnings for ILLink/NativeAot were updated to avoid relying on the name of the compiler-generated methods for lambdas or local functions, because the analyzer reports the warnings as: IL2111: Method 'lambda expression' with parameters... is accessed via reflection.
ghost
added
area-Meta
linkable-framework
|
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsThe ILLink analyzer was not producing warnings for annotated methods, lambdas, or local functions accessed for delegate creation. Some ExpectedWarnings for ILLink/NativeAot were updated to avoid relying on the name of the compiler-generated methods for lambdas or local functions, because the analyzer reports the warnings as: IL2111: Method 'lambda expression' with parameters... is accessed via reflection.
|
6 tasks
vitek-karas
reviewed
Sep 22, 2023
vitek-karas
approved these changes
Sep 22, 2023
vitek-karas
left a comment
vitek-karas
left a comment
Member
There was a problem hiding this comment.
Other than the RUC question - this looks good.
Member
Author
|
@dotnet-policy-service rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ILLink analyzer was not producing warnings for annotated methods, lambdas, or local functions accessed for delegate creation.
Some ExpectedWarnings for ILLink/NativeAot were updated to avoid relying on the name of the compiler-generated methods for lambdas or local functions, because the analyzer reports the warnings as:
IL2111: Method 'lambda expression' with parameters... is accessed via reflection.
Fixes #84918