Skip to content

[mono] Fix incorrect version comparison in loader#76665

Merged
akoeplinger merged 1 commit into
dotnet:mainfrom
uweigand:mono-assemblyversion-fix
Oct 6, 2022
Merged

[mono] Fix incorrect version comparison in loader#76665
akoeplinger merged 1 commit into
dotnet:mainfrom
uweigand:mono-assemblyversion-fix

Conversation

@uweigand

@uweigand uweigand commented Oct 5, 2022

Copy link
Copy Markdown
Contributor

This should be backported to .NET 7 and .NET 6 as well.

* Compare version components in the correct order in
  assembly_names_compare_versions

* Fixes #76664
@ghost ghost added area-AssemblyLoader-mono community-contribution Indicates that the PR has been added by a community member labels Oct 5, 2022
@ghost

ghost commented Oct 5, 2022

Copy link
Copy Markdown

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

This should be backported to .NET 7 and .NET 6 as well.

Author: uweigand
Assignees: -
Labels:

area-AssemblyLoader-mono

Milestone: -

@lambdageek

Copy link
Copy Markdown
Member

/backport to release/7.0

@lambdageek

Copy link
Copy Markdown
Member

/backport to release/6.0

@github-actions

github-actions Bot commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3194198853

@github-actions

github-actions Bot commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3194200068

@lambdageek

Copy link
Copy Markdown
Member

@akoeplinger this is probably worth porting to mono/mono 2020-02, as well

@akoeplinger akoeplinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Kind of amazing this got unnoticed so long 😄

@akoeplinger

Copy link
Copy Markdown
Member

/azp run sync-runtime-to-mono

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@akoeplinger

akoeplinger commented Oct 6, 2022

Copy link
Copy Markdown
Member

hm looks like the sync pipeline got lost in the dnceng-public migration somehow. @uweigand would you mind manually porting this to mono/mono?

uweigand added a commit to uweigand/mono that referenced this pull request Oct 6, 2022
@uweigand

uweigand commented Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

hm looks like the sync pipeline got lost in the dnceng-public migration somehow. @uweigand would you mind manually porting this to mono/mono?

mono/mono#21553

@akoeplinger akoeplinger merged commit 11b4ef9 into dotnet:main Oct 6, 2022
github-actions Bot pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
akoeplinger pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
* Backport dotnet/runtime#76665

Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
akoeplinger pushed a commit to mono/mono that referenced this pull request Oct 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-AssemblyLoader-mono community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mono] Incorrect version comparison in the loader

3 participants