Skip to content

Revert "Clean up AOT publish process"#74036

Closed
lewing wants to merge 1 commit into
mainfrom
revert-73416-CleanPublishAot
Closed

Revert "Clean up AOT publish process"#74036
lewing wants to merge 1 commit into
mainfrom
revert-73416-CleanPublishAot

Conversation

@lewing

@lewing lewing commented Aug 17, 2022

Copy link
Copy Markdown
Member

Reverts #73416 due to it setting PublishAot=true by default when used from the sdk dotnet/sdk#27149

@lewing

lewing commented Aug 17, 2022

Copy link
Copy Markdown
Member Author

I opened this to get the ball rolling, an alternate fix is fine

@lewing

lewing commented Aug 17, 2022

Copy link
Copy Markdown
Member Author

/backport to release/7.0-rc1

@jeffschwMSFT jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2872017660

@MichalStrehovsky

Copy link
Copy Markdown
Member

I suggest we take Sven's #74046 (backport in #74048) instead.

@MichalStrehovsky MichalStrehovsky added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 17, 2022
@lewing lewing closed this Aug 17, 2022
@akoeplinger akoeplinger deleted the revert-73416-CleanPublishAot branch August 18, 2022 15:34
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-NativeAOT-coreclr NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants