Skip to content

consume MsQuic 2.1 for windows ARM64 builds#73713

Merged
rzikm merged 3 commits into
dotnet:mainfrom
wfurt:winArmQuic
Aug 11, 2022
Merged

consume MsQuic 2.1 for windows ARM64 builds#73713
rzikm merged 3 commits into
dotnet:mainfrom
wfurt:winArmQuic

Conversation

@wfurt

@wfurt wfurt commented Aug 10, 2022

Copy link
Copy Markdown
Member

We don't have Windows ARM pipeline for msquic transport. This change consumes ARM bits published by msquic directly.
(This does not allow us easily consume daily builds & fixes but that should OK for now)

@wfurt wfurt requested a review from a team August 10, 2022 19:28
@wfurt wfurt self-assigned this Aug 10, 2022
@ghost

ghost commented Aug 10, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

We don't have Windows ARM pipeline for msquic transport. This change consumes ARM bits published by msquic directly.
(This does not allow us easily consume daily builds & fixes but that should OK for now)

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: -

@wfurt

wfurt commented Aug 10, 2022

Copy link
Copy Markdown
Member Author

btw

file artifacts/bin/testhost/net7.0-windows-Debug-arm64/shared/Microsoft.NETCore.App/7.0.0/msquic.dll
artifacts/bin/testhost/net7.0-windows-Debug-arm64/shared/Microsoft.NETCore.App/7.0.0/msquic.dll: PE32+ executable (DLL) (console) Aarch64, for MS Windows

@wfurt

wfurt commented Aug 11, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rzikm

rzikm commented Aug 11, 2022

Copy link
Copy Markdown
Member

I thought you had a PR to dotnet/msquic which would build the DLL for ARM so we could consume it as we do for x86/x64

@karelz karelz requested a review from rzikm August 11, 2022 10:11
@karelz

karelz commented Aug 11, 2022

Copy link
Copy Markdown
Member

@rzikm building on arm is problematic - this is easiest route. Even for Linux we are looking into cross-compilation on our side.

@rzikm rzikm merged commit 06c625b into dotnet:main Aug 11, 2022
@karelz

karelz commented Aug 11, 2022

Copy link
Copy Markdown
Member

Windows arm64 pipeline was cancelled - https://github.com/dotnet/runtime/runs/7782294163

  • runtime-extra-platforms (Libraries Test Run release coreclr windows arm64 Release)

@wfurt

wfurt commented Aug 11, 2022

Copy link
Copy Markdown
Member Author

It was not meant as permanent change. Sees like we don't have hardware so we will not get any windows arm tests @karelz.

@rzikm

rzikm commented Aug 11, 2022

Copy link
Copy Markdown
Member

Tested locally on Volterra device:

PS C:\source\runtime\artifacts\bin\System.Net.Quic.Functional.Tests\Debug\net7.0-windows> ..\..\..\testhost\net7.0-windows-Debug-arm64\dotnet.exe exec --runtimeconfig .\System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile .\System.Net.Quic.Functional.Tests.deps.json .\xunit.console.dll .\System.Net.Quic.Functional.Tests.dll -notrait category=failing -notrait category=outerloop
Microsoft.DotNet.XUnitConsoleRunner v2.5.0 (64-bit .NET 7.0.0-dev)
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 101 of 110 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 8)
    System.Net.Quic.Tests.MsQuicPlatformDetectionTests.UnsupportedPlatforms_ThrowsPlatformNotSupportedException [SKIP]
      Condition(s) not met: "IsQuicUnsupported"
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 320, Errors: 0, Failed: 0, Skipped: 1, Time: 71.638s

akoeplinger pushed a commit that referenced this pull request Aug 11, 2022
#73713 added Windows.11.Arm64.Open runs to check MsQuic functionality there, but currently, there is no HW servicing the queue and the ci job timeouts. This PR temporarily suspends runs on the queue until appropriate HW is deployed to helix.
@karelz karelz added this to the 7.0.0 milestone Aug 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants