Skip to content

Revert "Disable GetGCMemoryInfo on arm (#73477)"#73595

Merged
hoyosjs merged 1 commit into
dotnet:mainfrom
noahfalk:renable_gc_test
Aug 9, 2022
Merged

Revert "Disable GetGCMemoryInfo on arm (#73477)"#73595
hoyosjs merged 1 commit into
dotnet:mainfrom
noahfalk:renable_gc_test

Conversation

@noahfalk

@noahfalk noahfalk commented Aug 8, 2022

Copy link
Copy Markdown
Member

Fixes #73247

This reverts commit 9865cc7.
We believe the problematic change has been reverted so the test can be re-enabled.

This reverts commit 9865cc7.
We believe the problematic change has been reverted so the test can be re-enabled.
@ghost

ghost commented Aug 8, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned noahfalk Aug 8, 2022
@noahfalk

noahfalk commented Aug 8, 2022

Copy link
Copy Markdown
Member Author

@am11 @filipnavara @janvorli @jkoritzinsky @karelz

@noahfalk

noahfalk commented Aug 8, 2022

Copy link
Copy Markdown
Member Author

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@noahfalk

noahfalk commented Aug 8, 2022

Copy link
Copy Markdown
Member Author

@karelz - as new test-monitor can I hand this PR over to you to decide whether or not to merge it? I think the PR that reverted the pinvoke inlining did its ARM validation before this test got disabled and passed so I am reasonably confident that issue is solved. This PR just gets the test turned on again and confirms everything is still in good shape.

@noahfalk noahfalk assigned karelz and akoeplinger and unassigned noahfalk and karelz Aug 8, 2022
@filipnavara

Copy link
Copy Markdown
Member

Some of the pipelines unfortunately failed on the dotnet-install.sh script where HTML was received from the server instead of expected binary data...

@noahfalk noahfalk assigned karelz and unassigned akoeplinger Aug 9, 2022
@akoeplinger

Copy link
Copy Markdown
Member

I retried the failing jobs, let's see.

@hoyosjs

hoyosjs commented Aug 9, 2022

Copy link
Copy Markdown
Member

The Android JIT.Directed failures are tracked in #73539

@karelz

karelz commented Aug 10, 2022

Copy link
Copy Markdown
Member

@noahfalk sorry for late response, I didn't notice it until now.
I was a bit lost what reverted what and fixed what -- I updated the top post.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GC/API/GC/GetGCMemoryInfo/GetGCMemoryInfo.sh test failing intermittently on CoreCLR Linux ARM32

6 participants