Skip to content

Add TieredPGO and ReadyToRun to Microsoft-Windows-DotNETRuntime/TieredCompilation/Settings event#72056

Merged
eduardo-vp merged 18 commits into
dotnet:mainfrom
eduardo-vp:feature/add-tieredpgo-readytorun-flags
Aug 4, 2022
Merged

Add TieredPGO and ReadyToRun to Microsoft-Windows-DotNETRuntime/TieredCompilation/Settings event#72056
eduardo-vp merged 18 commits into
dotnet:mainfrom
eduardo-vp:feature/add-tieredpgo-readytorun-flags

Conversation

@eduardo-vp

Copy link
Copy Markdown
Member

Fixes #69820

@ghost ghost assigned eduardo-vp Jul 12, 2022
@ghost ghost added the area-VM-coreclr label Jul 12, 2022
@eduardo-vp eduardo-vp requested a review from kouvel July 12, 2022 23:27
Comment thread src/coreclr/vm/eventtrace.cpp Outdated

@kouvel kouvel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise LGTM

Comment thread src/coreclr/vm/eventtrace.cpp
Comment thread src/coreclr/vm/eeconfig.h
@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 13, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 14, 2022
@eduardo-vp eduardo-vp requested a review from jkotas July 14, 2022 18:45
Comment thread src/coreclr/vm/eeconfig.cpp Outdated
Comment thread src/coreclr/vm/eeconfig.cpp Outdated
Comment thread src/coreclr/vm/eeconfig.cpp Outdated
Comment thread src/coreclr/vm/readytoruninfo.cpp
@eduardo-vp eduardo-vp marked this pull request as ready for review August 3, 2022 00:05
@eduardo-vp eduardo-vp requested review from jkotas and kouvel August 3, 2022 00:09
@eduardo-vp

Copy link
Copy Markdown
Member Author

After the previous review, I set the value of ReadyToRun and TieredPGO before the event was fired (a bug of mine) and added a conditional on the ReadyToRun as the TieredPGO has one as well

Comment thread src/coreclr/vm/eeconfig.cpp Outdated
@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 3, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 3, 2022
Comment thread src/coreclr/vm/eeconfig.cpp
@eduardo-vp

Copy link
Copy Markdown
Member Author

/azp run runtime

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eduardo-vp eduardo-vp merged commit 0c4db6e into dotnet:main Aug 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It is difficult to determine whether TieredPGO and ReadyToRun are enabled

3 participants