Skip to content

[mono][wasm] Enable a subset of the gc_pin area optimizations. - #70465

Merged
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:wasm-opt-2
Jun 13, 2022
Merged

[mono][wasm] Enable a subset of the gc_pin area optimizations.#70465
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:wasm-opt-2

Conversation

@vargaz

@vargaz vargaz commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

The OP_ARG one causes random crashes.

@ghost ghost assigned vargaz Jun 9, 2022
@vargaz

vargaz commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical radical added the arch-wasm WebAssembly architecture label Jun 9, 2022
@ghost

ghost commented Jun 9, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The OP_ARG one causes random crashes.

Author: vargaz
Assignees: vargaz
Labels:

arch-wasm, area-Codegen-LLVM-mono

Milestone: -

@lewing

lewing commented Jun 10, 2022

Copy link
Copy Markdown
Member

you should be able to merge main to and avoid the trimmer errors

@vargaz

vargaz commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
vargaz requested a review from lambdageek June 11, 2022 14:04
@vargaz

vargaz commented Jun 12, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
vargaz merged commit 52077ff into dotnet:main Jun 13, 2022
@vargaz
vargaz deleted the wasm-opt-2 branch June 13, 2022 17:34
@ghost ghost locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Codegen-LLVM-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants