Skip to content

Wasm AOT micro optimizations - #69955

Merged
vargaz merged 10 commits into
dotnet:mainfrom
vargaz:wasm-opt
Jun 2, 2022
Merged

Wasm AOT micro optimizations#69955
vargaz merged 10 commits into
dotnet:mainfrom
vargaz:wasm-opt

Conversation

@vargaz

@vargaz vargaz commented May 28, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost assigned vargaz May 28, 2022
@vargaz
vargaz removed request for SamMonoRT and lambdageek May 28, 2022 23:05
@vargaz
vargaz marked this pull request as draft May 28, 2022 23:05
@vargaz

vargaz commented May 28, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented May 29, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz

vargaz commented May 29, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@teo-tsirpanis teo-tsirpanis added the arch-wasm WebAssembly architecture label May 29, 2022
@ghost

ghost commented May 29, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vargaz
Assignees: vargaz
Labels:

arch-wasm, area-Codegen-LLVM-mono

Milestone: -

@vargaz

vargaz commented May 31, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
vargaz force-pushed the wasm-opt branch 2 times, most recently from 808bff0 to 08cd26a Compare May 31, 2022 22:40
@vargaz

vargaz commented Jun 1, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

vargaz added 9 commits June 1, 2022 20:55
The arguments changed from pointers to byref types.
…rgctx () call as well.

This avoids the generation of an unused MONO_PATCH_INFO_GSHARED_METHOD_INFO.
LLVM generates correct single threaded code for these even if threads are not enabled.
Volatile vars are already stored into a stack location.
This affects ctors like ReadOnlySpan<T>.ctor ().
@vargaz

vargaz commented Jun 2, 2022

Copy link
Copy Markdown
Contributor Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargaz
vargaz marked this pull request as ready for review June 2, 2022 15:47
@vargaz
vargaz requested a review from BrzVlad as a code owner June 2, 2022 15:47
@vargaz
vargaz requested a review from lambdageek June 2, 2022 15:47
@vargaz
vargaz merged commit e3a4db9 into dotnet:main Jun 2, 2022
@vargaz
vargaz deleted the wasm-opt branch June 2, 2022 20:43
@ghost ghost locked as resolved and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Codegen-LLVM-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants