Skip to content

fix some test for FreeBSD #64426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wfurt merged 4 commits into from
Feb 4, 2022
Merged

fix some test for FreeBSD #64426

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c05c990
fix some test for FreeBSD
wfurt Jan 20, 2022
4cab6e6
remove changes in IPGlobalPropertiesTest
wfurt Jan 20, 2022
86dc927
disable AddLongHeader_DoesNotThrow
wfurt Jan 31, 2022
9739842
update description for skip
wfurt Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/System.Net.HttpListener/tests/HttpListenerPrefixCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,7 @@ public static IEnumerable<object[]> InvalidPrefix_TestData()

[Theory]
[MemberData(nameof(InvalidPrefix_TestData))]
[SkipOnPlatform(TestPlatforms.FreeBSD, "FreeBSD accepts some as valid and test hangs")]

@stephentoub stephentoub Feb 1, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"accepts some as valid"... some what? I'm not understanding the comment.

@wfurt wfurt Feb 1, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some items from InvalidPrefix_TestData. http://192./ for example. I did not dig deeper why that is happening.

public void Add_InvalidPrefixNotStarted_ThrowsHttpListenerExceptionOnStart(string uriPrefix)
{
var listener = new HttpListener();
Expand All @@ -371,6 +372,7 @@ public void Add_InvalidPrefixNotStarted_ThrowsHttpListenerExceptionOnStart(strin

[Theory]
[MemberData(nameof(InvalidPrefix_TestData))]
[SkipOnPlatform(TestPlatforms.FreeBSD, "FreeBSD accepts some as valid and test hangs")]
public void Add_InvalidPrefixAlreadyStarted_ThrowsHttpListenerExceptionOnAdd(string uriPrefix)
{
using (var factory = new HttpListenerFactory())
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Net.HttpListener/tests/HttpListenerResponseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,7 @@ public async Task CloseResponseEntity_SendToClosedConnection_DoesNotThrow(bool w
}

[Fact]
[SkipOnPlatform(TestPlatforms.FreeBSD, "unreliable on FreeBSD")]
public async Task AddLongHeader_DoesNotThrow()
{
string longString = new string('a', 65536);
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.HttpListener/tests/HttpResponseStreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ public async Task Write_ContentToClosedConnectionAsynchronously_ThrowsHttpListen
[InlineData(true)]
[InlineData(false)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/21022", platforms: TestPlatforms.Windows)] // Indeterminate failure - socket not always fully disconnected.
[ActiveIssue("https://github.com/dotnet/runtime/issues/21590", TestPlatforms.OSX)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/21590", TestPlatforms.OSX | TestPlatforms.FreeBSD)]
public async Task Write_ContentToClosedConnectionSynchronously_ThrowsHttpListenerException(bool ignoreWriteExceptions)
{
const string Text = "Some-String";
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Net.Security/tests/FunctionalTests/TestConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ internal static class TestConfiguration
public const string NtlmUserFilePath = "/var/tmp/ntlm_user_file";

public static bool SupportsNullEncryption { get { return s_supportsNullEncryption.Value; } }
public static bool SupportsHandshakeAlerts { get { return OperatingSystem.IsLinux() || OperatingSystem.IsWindows(); } }
public static bool SupportsHandshakeAlerts { get { return OperatingSystem.IsLinux() || OperatingSystem.IsWindows() || OperatingSystem.IsFreeBSD(); } }
public static bool SupportsRenegotiation { get { return (OperatingSystem.IsWindows() && !PlatformDetection.IsWindows7) || ((OperatingSystem.IsLinux() || OperatingSystem.IsFreeBSD()) && PlatformDetection.OpenSslVersion >= new Version(1, 1, 1)); } }

public static Task WhenAllOrAnyFailedWithTimeout(params Task[] tasks)
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/SendTo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ public async Task Datagram_UDP_ShouldImplicitlyBindLocalEndpoint()
}

[Fact]
[SkipOnPlatform(TestPlatforms.FreeBSD, "FreeBSD allows sendto() to broadcast")]
public async Task Datagram_UDP_AccessDenied_Throws_DoesNotBind()
{
IPEndPoint invalidEndpoint = new IPEndPoint(IPAddress.Broadcast, 1234);
Expand Down
5 changes: 3 additions & 2 deletions src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ public void SetIPProtectionLevel_ArgumentException(AddressFamily family)
}
}

[Theory]
[ConditionalTheory]
[InlineData(AddressFamily.InterNetwork)]
[InlineData(AddressFamily.InterNetworkV6)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50568", TestPlatforms.Android)]
Expand All @@ -515,6 +515,7 @@ public void GetSetRawSocketOption_Roundtrips(AddressFamily family)
int SO_RCVBUF;

if (OperatingSystem.IsWindows() ||
OperatingSystem.IsFreeBSD() ||
OperatingSystem.IsMacOS())
{
SOL_SOCKET = 0xffff;
Expand Down Expand Up @@ -558,7 +559,7 @@ public void Get_AcceptConnection_Succeeds()
s.Bind(new IPEndPoint(IPAddress.Loopback, 0));
s.Listen();

Assert.Equal(1, s.GetSocketOption(SocketOptionLevel.Socket, SocketOptionName.AcceptConnection));
Assert.NotEqual(0, s.GetSocketOption(SocketOptionLevel.Socket, SocketOptionName.AcceptConnection));
}
}

Expand Down