Temporarily disable arm64 intrinsics in UTF-16 validation code paths#42052
Merged
Conversation
GrabYourPitchforks
added
area-System.Runtime
tenet-performance
GrabYourPitchforks
requested review from
adamsitnik,
carlossanlop,
kunalspathak,
pgovind and
tannergooding
adamsitnik
approved these changes
Sep 10, 2020
adamsitnik
left a comment
adamsitnik
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you @GrabYourPitchforks !
I've re-run the failed CI legs, as soon as they go green I squash the PR
21 tasks
Contributor
|
/backport to release/5.0-rc2 |
Contributor
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/247917869 |
Contributor
|
@adamsitnik should someone verify the perf effect of this before back port is merged? |
Member
yes. I would love to do it, but I can't build the runtime repo on Windows ARM64 #42008 ;) |
Contributor
|
Is it possible to cross compile corelib dll and copy it over? I know it's a hassle until we fix the issue you mention. |
Contributor
|
All done thanks @carlossanlop |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41699.
Disables the ARM64-intrinsicified UTF-16 validation code paths since they ended up having poorer performance characteristics for non-ASCII data compared to their 3.x counterparts. With this PR, we skip the intrinsics entirely but stay within vectorized code as much as possible. The codegen and perf should be on-par with what shipped in 3.x.
Once this change is in, we can re-introduce tweaked versions of the arm64 code path, validate the perf numbers, and cherry-pick the "real" fix into the 5.x servicing branches.
/cc @jeffhandley