Skip to content

Update SDK min and target version to >= Preview8#41947

Merged
ViktorHofer merged 26 commits into
masterfrom
ViktorHofer-sdkupdate
Sep 10, 2020
Merged

Update SDK min and target version to >= Preview8#41947
ViktorHofer merged 26 commits into
masterfrom
ViktorHofer-sdkupdate

Conversation

@ViktorHofer

@ViktorHofer ViktorHofer commented Sep 7, 2020

Copy link
Copy Markdown
Member

Update the SDK min version to Preview 8 final and update the target version to RC.1 latest.

Fixes #38902

Update the SDK min version to Preview 8 final and update the target version to RC.1 latest.
@ViktorHofer ViktorHofer self-assigned this Sep 7, 2020
@Dotnet-GitSync-Bot

Copy link
Copy Markdown
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer ViktorHofer requested a review from a team September 9, 2020 14:12
Comment thread src/libraries/pkg/test/project.csproj.template
@ViktorHofer

Copy link
Copy Markdown
Member Author

Merging as all other legs already passed in the previous run and the allconfigurations now succeeded as well.

@ViktorHofer ViktorHofer merged commit ad434fc into master Sep 10, 2020
@ViktorHofer ViktorHofer deleted the ViktorHofer-sdkupdate branch September 10, 2020 08:50
@BruceForstall

BruceForstall commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

@ViktorHofer @dotnet/runtime-infrastructure It looks like this change broke coreclr outerloop testing:

https://dev.azure.com/dnceng/public/_build/results?buildId=809051&view=results

Which means all pri-1 testing will fail

@safern

safern commented Sep 11, 2020

Copy link
Copy Markdown
Member

I believe @jkoritzinsky was taking a look at this?

@jkoritzinsky

Copy link
Copy Markdown
Member

Yep I'm looking at this today.

@BruceForstall

Copy link
Copy Markdown
Contributor

@jkoritzinsky Are you still looking? Every test leg is failing this weekend.

@jkoritzinsky

Copy link
Copy Markdown
Member

#42146 will fix it, but it hasn't been merged in yet.

@trylek

trylek commented Sep 12, 2020

Copy link
Copy Markdown
Member

OK, let me put out the PR for disabling the one test for now in issues.targets to unblock the pipeline.

@trylek

trylek commented Sep 12, 2020

Copy link
Copy Markdown
Member

I guess the interesting question is when the PR can be realistically merged in. If that's just around the bend, blocking the test out would cause more churn than good, but if we only get to it on Tuesday, it will be a grim Thursday at the CI council meeting ;-).

@BruceForstall

Copy link
Copy Markdown
Contributor

I opened #42168 to track this.

btw, it looks like there are many thousands of warnings in the test build that I don't remember seeing before.

@trylek

trylek commented Sep 12, 2020

Copy link
Copy Markdown
Member

I asked about that on the internal infra e-mail alias and my understanding is that this is due to some more stringent checks in new Roslyn. Which is an interesting question, perhaps @jaredpar may have thoughts on what is the preferable way forward - either booking the time to clean the tests up to conform with the latest compiler version, or treating them as "set in stone" (which may be more appropriate e.g. for various regression tests) and maybe devising a new way to mark newly added tests as (potentially) conforming to a more stringent warning policy employed by the newest C# compiler.

@trylek

trylek commented Sep 12, 2020

Copy link
Copy Markdown
Member

Hmm, my bad, it's not as easy as blocking the test out in issues.targets as that only kicks in when building the XUnit test wrappers, not upon test build as such. I guess the easiest way forward (without the actual fix) is to either mark the test as Pri2 or block it out using the DisabledProjects item group in src/coreclr/tests/src/dirs.proj for now.

ViktorHofer added a commit to ViktorHofer/runtime that referenced this pull request Sep 15, 2020
* Update SDK min and target version to >= Preview8
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows ARM64 build gets stuck at installer.tasks

7 participants