Fix tailCall check for for calli.#39621
Merged
Merged
Conversation
sandreenko
added
the
area-CodeGen-coreclr
Contributor
Author
|
PTAL @dotnet/jit-contrib |
Contributor
|
Looks good but I think you have it backwards in the title and the description: this fixes calli case, not !calli. |
sandreenko
changed the title
Contributor
Author
You are right, thanks. |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we can see from
runtime/src/coreclr/src/jit/importer.cpp
Line 7641 in f4e9146
runtime/src/coreclr/src/jit/importer.cpp
Lines 7653 to 7655 in f4e9146
in
impImportCallthe correct signature is saved insig.callInfo->sigis correct for!CEE_CALLI,calliSigis used forCEE_CALLI.Fixes #39556 (It fixes new 2 failures out of 34, but the other are expected
InvalidProgramException).