Use a different approach to optimize the indirect calls for R2R#36712
Closed
kunalspathak wants to merge 1 commit into
Closed
Use a different approach to optimize the indirect calls for R2R#36712kunalspathak wants to merge 1 commit into
kunalspathak wants to merge 1 commit into
Conversation
During lowering, don't create a controlExpr for indirect call. Instead use temp register for such calls and during codegen, load the indirect from x11 into that temp register before calling the address in that temp register.
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
CarolEidt
approved these changes
May 19, 2020
CarolEidt
left a comment
CarolEidt
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestions
Contributor
Author
|
Ported to #35675 and merged. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During lowering, don't create a controlExpr for indirect call. Instead use
temp register for such calls and during codegen, load the indirect from x11
into that temp register before calling the address in that temp register.