Skip to content

Disable test using gc cover on interpreter - #132199

Merged
BrzVlad merged 2 commits into
dotnet:mainfrom
BrzVlad:disable-interp-gc-cover
Aug 13, 2026
Merged

Disable test using gc cover on interpreter#132199
BrzVlad merged 2 commits into
dotnet:mainfrom
BrzVlad:disable-interp-gc-cover

Conversation

@BrzVlad

@BrzVlad BrzVlad commented Aug 12, 2026

Copy link
Copy Markdown
Member

GC coverage (GCStress=4) only supports jitted code.

Test enabled in #131881

GC coverage (GCStress=4) only supports jitted code.
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @anicka-net, @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Marks the GC regression test Runtime_129681 as incompatible with interpreter-based test runs, aligning the test harness behavior with the fact that GCStress-based instruction stress is only supported for JITted code.

Changes:

  • Add InterpreterIncompatible metadata to skip this test when the interpreter is enabled.
  • Document (via an MSBuild comment) why the test is skipped under the interpreter.

Comment thread src/tests/GC/Regressions/Github/Runtime_129681/Runtime_129681.csproj Outdated
Comment thread src/tests/GC/Regressions/Github/Runtime_129681/Runtime_129681.csproj Outdated
Copilot AI review requested due to automatic review settings August 13, 2026 10:03
@BrzVlad

BrzVlad commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

/azp run runtime-interpreter

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/tests/JIT/Regression/JitBlue/GitHub_27924/GitHub_27924.csproj:5

  • RequiresProcessIsolation is currently justified as being needed for CLRTestBatchEnvironmentVariable, but this project no longer sets any CLRTest*EnvironmentVariable items. Keeping process isolation here unnecessarily prevents test runner merging and adds extra process overhead.

Consider removing the isolation property (and the now-stale comment), unless there's another isolation requirement not documented in the project file.

  <PropertyGroup>
    <!-- Needed for CLRTestBatchEnvironmentVariable -->
    <RequiresProcessIsolation>true</RequiresProcessIsolation>
  </PropertyGroup>

We already have a dedicated pipeline running all tests in this configuration.
Copilot AI review requested due to automatic review settings August 13, 2026 10:18
@BrzVlad
BrzVlad force-pushed the disable-interp-gc-cover branch from 182ddf4 to 6d0fc3b Compare August 13, 2026 10:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/tests/JIT/Regression/JitBlue/Runtime_45090/Runtime_45090.csproj:5

  • Removing the per-test DOTNET_GCStress=0xC configuration changes this regression test from running under GC coverage/stress to running under default GC settings. If the regression still requires GCStress/C to reproduce (as the previous project comment implied), the test may no longer provide reliable coverage. Consider setting DOTNET_GCStress only when not running under the interpreter (RunInterpreter/DOTNET_InterpMode) instead of removing it entirely.
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <DebugType>None</DebugType>
    <Optimize>True</Optimize>
    <AllowUnsafeBlocks>True</AllowUnsafeBlocks>

src/tests/JIT/Regression/JitBlue/GitHub_27924/GitHub_27924.csproj:5

  • The project file no longer forces DOTNET_GCStress=0xC, but the removed comment indicated GCStress/C was required to reliably trigger the regression. If that is still true, this change risks turning the test into a "non-repro" under normal runs. One option is to keep setting DOTNET_GCStress for Windows runs, but gate it off when running under the interpreter (RunInterpreter/DOTNET_InterpMode).
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <DebugType>None</DebugType>
    <Optimize>True</Optimize>
  </PropertyGroup>

@BrzVlad

BrzVlad commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

/ba-g unrelated failures

@BrzVlad
BrzVlad merged commit 2580b59 into dotnet:main Aug 13, 2026
81 of 84 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants