Disable test using gc cover on interpreter - #132199
Conversation
GC coverage (GCStress=4) only supports jitted code.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
There was a problem hiding this comment.
Pull request overview
Marks the GC regression test Runtime_129681 as incompatible with interpreter-based test runs, aligning the test harness behavior with the fact that GCStress-based instruction stress is only supported for JITted code.
Changes:
- Add
InterpreterIncompatiblemetadata to skip this test when the interpreter is enabled. - Document (via an MSBuild comment) why the test is skipped under the interpreter.
|
/azp run runtime-interpreter |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/tests/JIT/Regression/JitBlue/GitHub_27924/GitHub_27924.csproj:5
RequiresProcessIsolationis currently justified as being needed forCLRTestBatchEnvironmentVariable, but this project no longer sets anyCLRTest*EnvironmentVariableitems. Keeping process isolation here unnecessarily prevents test runner merging and adds extra process overhead.
Consider removing the isolation property (and the now-stale comment), unless there's another isolation requirement not documented in the project file.
<PropertyGroup>
<!-- Needed for CLRTestBatchEnvironmentVariable -->
<RequiresProcessIsolation>true</RequiresProcessIsolation>
</PropertyGroup>
We already have a dedicated pipeline running all tests in this configuration.
182ddf4 to
6d0fc3b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/tests/JIT/Regression/JitBlue/Runtime_45090/Runtime_45090.csproj:5
- Removing the per-test DOTNET_GCStress=0xC configuration changes this regression test from running under GC coverage/stress to running under default GC settings. If the regression still requires GCStress/C to reproduce (as the previous project comment implied), the test may no longer provide reliable coverage. Consider setting DOTNET_GCStress only when not running under the interpreter (RunInterpreter/DOTNET_InterpMode) instead of removing it entirely.
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<DebugType>None</DebugType>
<Optimize>True</Optimize>
<AllowUnsafeBlocks>True</AllowUnsafeBlocks>
src/tests/JIT/Regression/JitBlue/GitHub_27924/GitHub_27924.csproj:5
- The project file no longer forces DOTNET_GCStress=0xC, but the removed comment indicated GCStress/C was required to reliably trigger the regression. If that is still true, this change risks turning the test into a "non-repro" under normal runs. One option is to keep setting DOTNET_GCStress for Windows runs, but gate it off when running under the interpreter (RunInterpreter/DOTNET_InterpMode).
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<DebugType>None</DebugType>
<Optimize>True</Optimize>
</PropertyGroup>
|
/ba-g unrelated failures |
GC coverage (GCStress=4) only supports jitted code.
Test enabled in #131881