Use minipal timers directly in GC

[Copilot]

Fixes #126551 (comment)

• Remove GC low- and high-resolution timer wrappers from GCToOSInterface.
• Replace GC callers with minipal_lowres_ticks, minipal_hires_ticks, and minipal_hires_tick_frequency.
• Keep platform-specific timer implementation centralized in minipal; no build-time availability checks added.

[Copilot]

Copilot wasn't able to review any files in this pull request.

[azure-pipelines]

Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Suppressed comments (1)

src/coreclr/gc/env/gcenv.os.h:14

• The PR metadata claims to fix #126551 (QueryUnbiasedInterruptTime availability), but this change only switches GC call sites to minipal_lowres_ticks()/minipal_hires_ticks() without adding the requested availability check/fallback. minipal_lowres_ticks() on Windows still calls QueryUnbiasedInterruptTime unconditionally, so the original partition-availability concern remains. Please either (a) implement the feature check + fallback in minipal (and align other call sites), or (b) drop the “Fixes #126551” linkage / update the PR scope accordingly.

#include <minipal/mutex.h>
#include <minipal/time.h>

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

Suppressed comments (3)

src/coreclr/gc/mark_phase.cpp:2085

• These dprintf calls use %d but pass an int64_t tick delta (minipal_lowres_ticks() - begin_tick). This is a varargs type mismatch (undefined behavior) on some ABIs; use a 64-bit format specifier consistent with the rest of the GC logging.

                    dprintf (SNOOP_LOG, ("heap%d: marking %zx from %d [%d] tl:%dms",
                            heap_number, (size_t)o, (heap_number+1)%n_heaps, level,
                            (minipal_lowres_ticks()-begin_tick)));

src/coreclr/gc/mark_phase.cpp:2094

• This dprintf call uses %d/%d for millisecond tick deltas, but the arguments are int64_t (minipal_lowres_ticks() - start_tick / - begin_tick). This is a varargs type mismatch; update the format string to 64-bit specifiers.

                    dprintf (SNOOP_LOG, ("heap%d: done marking %zx from %d [%d] %dms tl:%dms",
                            heap_number, (size_t)o, (heap_number+1)%n_heaps, level,
                            (minipal_lowres_ticks()-start_tick),(minipal_lowres_ticks()-begin_tick)));

src/coreclr/gc/env/gcenv.os.h:14

• PR description says this fixes #126551 (QueryUnbiasedInterruptTime availability), but after switching GC call sites to minipal_lowres_ticks() the underlying implementation in src/native/minipal/time.c still calls QueryUnbiasedInterruptTime unconditionally and asserts on failure. If this API is missing on some Windows partitions, the regression remains—just centralized in minipal. Consider implementing the proposed feature check/fallback (e.g. to GetTickCount64) in minipal before marking the issue as fixed.

#include <minipal/mutex.h>
#include <minipal/time.h>

[dotnet-policy-service]

Tagging subscribers to this area: @anicka-net, @dotnet/gc
See info in area-owners.md if you want to be subscribed.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Suppressed comments (1)

src/coreclr/gc/env/gcenv.os.h:14

• This change routes GC low-res timing through minipal_lowres_ticks() (via <minipal/time.h>), but minipal_lowres_ticks() on Windows still calls QueryUnbiasedInterruptTime unconditionally (see src/native/minipal/time.c). If the PR is intended to fix #126551 (API not available in some Windows partitions), this refactor alone doesn’t address the missing-API problem; the fix likely needs to be implemented in minipal (fallback to GetTickCount64 / dynamic lookup) and then consumed here.

#include <minipal/mutex.h>
#include <minipal/time.h>

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/coreclr/gc/env/gcenv.os.h:14

• This change routes GC low-res timing through minipal_lowres_ticks(), but on Windows the minipal implementation still calls QueryUnbiasedInterruptTime directly (see src/native/minipal/time.c). That means the original problem in #126551 (API not present in some Windows partitions, causing link/load failures) is not actually avoided by moving the callsite into minipal unless minipal also has an availability fallback (e.g., GetProcAddress + GetTickCount64 fallback, or a build-time feature macro).

#include <minipal/mutex.h>
#include <minipal/time.h>

[jkotas]

/ba-g build analysis misclassifying known failures - dotnet/arcade#17340