Update version of helix.jobmonitor to 11.0.0-beta.26406.8 - #131969
Update version of helix.jobmonitor to 11.0.0-beta.26406.8#131969mmitche wants to merge 18 commits into
Conversation
Contains a fix for retries of test uploads
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned .NET local tool version for microsoft.dotnet.helix.jobmonitor to a newer 11.0.0-beta build, so the repo’s dotnet tool restore / Helix job monitor usage picks up the intended fix.
Changes:
- Bump
microsoft.dotnet.helix.jobmonitorfrom11.0.0-beta.26404.8to11.0.0-beta.26406.8in the local tool manifest.
|
Hopefully this will fix the job stuck here https://dev.azure.com/dnceng-public/public/_build/results?buildId=1543009&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=078edc60-2a90-5618-e72d-426a045b11f0 |
|
Tagging subscribers to this area: @dotnet/area-meta |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7a9af9ab-d2e9-4097-a50b-ac179b9486de
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The Helix Job Monitor version bump is only applied to the local tool manifest here, but the repo still pins Microsoft.DotNet.Helix.JobMonitor to 11.0.0-beta.26404.8 in eng/Version.Details.xml and eng/Version.Details.props (similar tools like XHarness are kept in sync). This leaves two different "source of truth" versions in the repo and can cause confusion / dependency-flow churn; please update the Arcade dependency pins as well (or explain why this tool is intentionally diverging from Version.Details).
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26406.8",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The PR title indicates updating helix.jobmonitor to
11.0.0-beta.26406.8, but the tool manifest pins11.0.0-beta.26407.3. Please align the pinned version with the intended update (or update the PR title/description to match) to avoid confusion when tracking tool rollouts.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26407.3",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The PR title says the helix.jobmonitor version is being updated to
11.0.0-beta.26406.8, but the tool manifest is actually updated to11.0.0-beta.26411.1. Please align these (either update the PR title/description to match the version being shipped, or change the version here if26406.8is the intended target).
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26411.1",
"commands": [
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The PR title says the helix.jobmonitor version is being updated to 11.0.0-beta.26406.8, but this change pins microsoft.dotnet.helix.jobmonitor to 11.0.0-beta.26411.1. Please align the PR title/description with the version actually being used, or update the manifest to the intended version.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26411.1",
"commands": [
Removed the verbose flag from the Helix job monitor command.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- PR title says update helix.jobmonitor to 11.0.0-beta.26406.8, but the actual change sets it to 11.0.0-beta.26411.1 (from 26407.8). Please align the PR title/description with the version being introduced, or adjust the version here to match the stated target.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.26411.1",
"commands": [
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a3a2b2f-e044-4835-8a3c-0c99a6a29484
|
/azp run runtime |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Update to Job Monitor 11.0.0-beta.31411.7, which distinguishes independent logical Helix jobs submitted by the same AzDO job to the same queue so same-named passing work items cannot erase failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a3a2b2f-e044-4835-8a3c-0c99a6a29484
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/runtime.yml:58
enableHelixJobMonitoris defined twice with the same value. Since nothing between these entries redefines it, the second definition is redundant and makes it unclear which value is intended to be authoritative. Consider keeping a single definition with a comment that references the actual default being overridden.
# Keep the monitor enabled in the PR merge even when the target branch
# temporarily changes the default above.
- name: enableHelixJobMonitor
value: true
.config/dotnet-tools.json:31
- The PR title says the JobMonitor is being updated to
11.0.0-beta.26406.8, but the tool manifest pinsmicrosoft.dotnet.helix.jobmonitorto11.0.0-beta.31411.7. Please align the pinned version (or update the PR title/description if31411.7is the intended version).
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.31411.7",
"commands": [
Update to Job Monitor 11.0.0-beta.31411.8, which uses System.PhaseName to keep independent runtime matrix jobs distinct even when they share System.JobName=__default, queue, logical scenario, and work-item names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a3a2b2f-e044-4835-8a3c-0c99a6a29484
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.config/dotnet-tools.json:31
- The PR title says helix.jobmonitor is being updated to 11.0.0-beta.26406.8, but the tool manifest pins microsoft.dotnet.helix.jobmonitor to 11.0.0-beta.31411.8. Please align the PR description/title and the pinned version so reviewers know which build is intended (and so we can trace the source of the retry fix).
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.31411.8",
"commands": [
Use package 11.0.0-beta.31411.9 to validate attempt-aware retry lineage in runtime CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a3a2b2f-e044-4835-8a3c-0c99a6a29484
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/runtime.yml:54
enableHelixJobMonitoris defined twice with the same value. Since the later definition already forces the override after the variable templates, the earlier block is redundant and makes it harder to reason about which value is intended.
- name: enableHelixJobMonitor
value: true
- template: /eng/pipelines/helix-platforms.yml
.config/dotnet-tools.json:31
- The PR metadata says this updates helix.jobmonitor to
11.0.0-beta.26406.8, but the manifest is being updated to11.0.0-beta.31411.9. Please align the PR title/description and the tool version so reviewers can confirm the intended tool build (and that it contains the needed fix).
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.31411.9",
"commands": [
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a3a2b2f-e044-4835-8a3c-0c99a6a29484
|
/azp run runtime |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run runtime |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a3a2b2f-e044-4835-8a3c-0c99a6a29484
|
/azp run runtime |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (3)
eng/pipelines/runtime.yml:78
testResultUploadParallelism: 48is a significant deviation from the template default (8). Please add a brief rationale inline so future maintainers understand why this value is safe and necessary (and can tune it if AzDO/Helix throttles).
testResultUploadParallelism: 48
eng/pipelines/runtime.yml:58
enableHelixJobMonitoris already set totrueearlier in this file (immediately after importing/eng/pipelines/common/variables.yml), and/eng/pipelines/helix-platforms.ymldoes not currently override it. This second definition is redundant and the comment is misleading, which makes the variables section harder to reason about.
This issue also appears on line 78 of the same file.
# Keep the monitor enabled in the PR merge even when the target branch
# temporarily changes the default above.
- name: enableHelixJobMonitor
value: true
.config/dotnet-tools.json:30
- The PR title says the Helix job monitor is being updated to
11.0.0-beta.26406.8, but the tool manifest pinsmicrosoft.dotnet.helix.jobmonitorto11.0.0-beta.31411.10(and the previous value was11.0.0-beta.26407.8). Please align the PR title/description with the actual version being consumed, or adjust the pinned version if the title is the intended target.
"version": "11.0.0-beta.31411.10",
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/runtime.yml:58
- The pipeline variable
enableHelixJobMonitoris currently set twice (firstfalse, then immediately overridden totrue). This makes the earlier assignment dead code and is easy to misread when troubleshooting pipeline behavior. Consider keeping a single definition that clearly documents the intended override source.
# Keep the monitor enabled in the PR merge even when the target branch
# temporarily changes the default above.
- name: enableHelixJobMonitor
value: true
.config/dotnet-tools.json:31
- The PR title says this updates helix.jobmonitor to
11.0.0-beta.26406.8, but the pinned tool version here is11.0.0-beta.31411.10. Please align the pinned version and the PR metadata (title/description) so it’s clear what’s actually being consumed by CI.
"microsoft.dotnet.helix.jobmonitor": {
"version": "11.0.0-beta.31411.10",
"commands": [
Contains a fix for retries of test uploads