[browser][CoreCLR] Drop coreVfs resource support from loader#130784
Merged
Conversation
Co-authored-by: pavelsavara <271576+pavelsavara@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pavelsavara
July 15, 2026 14:21
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
pavelsavara
added
arch-wasm
pavelsavara
temporarily deployed
to
copilot-pat-pool
July 15, 2026 14:25 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
pavelsavara
changed the title
pavelsavara
temporarily deployed
to
copilot-pat-pool
July 15, 2026 14:25 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
pavelsavara
marked this pull request as ready for review
July 15, 2026 16:34
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the coreVfs resource bucket from the CoreCLR/browser JavaScript loader pipeline, including the runtime startup download path, config resource normalization/merging, prefetch behavior, and the exported TypeScript types.
Changes:
- Removed
coreVfshandling from loader config merge/normalize logic. - Removed
coreVfsdownload/await and prefetch enqueue paths in the CoreCLR loader. - Updated the public
Assetstype and regenerateddotnet.d.tsaccordingly.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/native/libs/Common/JavaScript/types/public-api.ts | Removes coreVfs from the exported Assets interface. |
| src/native/libs/Common/JavaScript/loader/config.ts | Drops coreVfs from mergeResources and normalizeResources. |
| src/native/libs/Common/JavaScript/loader/run.ts | Removes the coreVfs fetch/await from createRuntime. |
| src/native/libs/Common/JavaScript/loader/assets.ts | Removes coreVfs from prefetch queueing. |
| src/native/libs/Common/JavaScript/loader/dotnet.d.ts | Regenerated typings without coreVfs in Assets. |
This was referenced Jul 16, 2026
Open
maraf
approved these changes
Jul 16, 2026
pavelsavara
temporarily deployed
to
copilot-pat-pool
July 16, 2026 07:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
pavelsavara
temporarily deployed
to
copilot-pat-pool
July 16, 2026 07:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
pavelsavara
temporarily deployed
to
copilot-pat-pool
July 16, 2026 07:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
pavelsavara
temporarily deployed
to
copilot-pat-pool
July 16, 2026 07:42 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
radekdoulik
approved these changes
Jul 16, 2026
Member
|
/ba-g unrelated failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121486
The
coreVfsresource bucket was added to loadruntimeconfiginto the VFS before runtime startup. Since runtimeconfig is now embedded in the boot config,coreVfsis obsolete. This removes it from the CoreCLR/Browser loader only, leaving the Mono flavor and the shared SDK build tasks untouched.Changes (
src/native/libs/Common/JavaScript)loader/config.ts— dropcoreVfsfrommergeResourcesandnormalizeResourcesloader/run.ts— remove thecoreVfsfetch promise and itsawaitloader/assets.ts— remove thecoreVfsprefetch enqueuetypes/public-api.ts— remove thecoreVfsmember from theAssetsinterfaceloader/dotnet.d.ts— regenerated withoutcoreVfs(matches the source edit)Scope
Mono (
src/mono/browser/runtime) and the sharedMicrosoft.NET.Sdk.WebAssembly.Pack.Tasksstill emit/consumecoreVfs, so any boot config carrying it is simply ignored by the CoreCLR loader.