[clr-ios] Default Apple mobile CoreCLR ReadyToRun to composite regardless of BuildTestsOnHelix#130402
Merged
kotlarmilos merged 1 commit intoJul 10, 2026
Conversation
…less of BuildTestsOnHelix The composite and macho defaults sat in a property group gated on BuildTestsOnHelix != true, so a test that enables ReadyToRun while building with BuildTestsOnHelix=true fell back to the SDK default of non-composite pe. Move the composite and container-format defaults into a group keyed on PublishReadyToRun so composite macho is the default whenever ReadyToRun is on, and keep the PublishReadyToRun default gated on BuildTestsOnHelix != true so library tests still build IL only in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Apple mobile MSBuild defaults so CoreCLR ReadyToRun builds consistently use composite R2R with Mach-O container format whenever PublishReadyToRun=true, even when building with BuildTestsOnHelix=true.
Changes:
- Split the existing ReadyToRun defaults so
PublishReadyToRunremains gated onBuildTestsOnHelix != 'true', while composite/container-format defaults are gated onPublishReadyToRun == 'true'. - Make
PublishReadyToRunCompositeandPublishReadyToRunContainerFormattrue/machoonly when they’re otherwise unset (avoids overriding explicit settings).
Show a summary per file
| File | Description |
|---|---|
| src/mono/msbuild/apple/build/AppleBuild.props | Moves composite/container-format defaults into a PublishReadyToRun==true-keyed group so Mach-O composite is the default whenever R2R is enabled. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
kotlarmilos
added
area-Infrastructure-coreclr
Contributor
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
BrzVlad
approved these changes
Jul 9, 2026
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidnguyen-tech
approved these changes
Jul 9, 2026
This was referenced Jul 9, 2026
Open
This was referenced Jul 9, 2026
vitek-karas
approved these changes
Jul 10, 2026
Member
Author
|
/ba-g unrelated extra-platforms errors, the binlog shows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The composite and macho defaults for Apple mobile CoreCLR ReadyToRun were gated on
BuildTestsOnHelix != 'true', so a test that enables ReadyToRun while building withBuildTestsOnHelix=true, which is whyiOS.CoreCLR.R2R.Testpublished per-assemblypewhile every other Apple mobile CoreCLR image is composite macho.