Fix marshaller signature parameter index handling#130238
Draft
MichalStrehovsky with Copilot wants to merge 4 commits into
Draft
Fix marshaller signature parameter index handling#130238MichalStrehovsky with Copilot wants to merge 4 commits into
MichalStrehovsky with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
MichalStrehovsky
July 6, 2026 07:35
View session
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
This was referenced Jul 6, 2026
Open
Member
|
@copilot delete the unit test added in this PR. instead add a functional test under src/tests/Interop/PInvoke/Miscellaneous/CopyCtor/ |
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A marshalling check used the sparse parameter metadata cursor where it needed the signature parameter index. This caused copy-constructor custom modifiers to be evaluated against the wrong parameter when metadata was missing or sparse.