[clr-ios] Preserve inherited MemberData statics on maccatalyst CoreCLR#128409
Merged
kotlarmilos merged 13 commits intoJun 16, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts a handful of library test cases to run (or skip) correctly on newly-enabled CoreCLR Apple mobile test legs by updating xUnit data discovery patterns and adding platform/trimming-related guards.
Changes:
- Add/adjust theory data sourcing to avoid xUnit
MemberDataresolution problems in derived/overridden conformance tests. - Skip or expand existing platform exclusions for tests that rely on desktop-only behaviors (e.g., TPA/fusion log details, reflection emit under aggressive trimming).
- Expand an existing
ActiveIssueto include MacCatalyst and gate a debugger-proxy test away from NativeAOT.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/tests/CryptoStream.cs | Adds an override using explicit MemberType for MemberData to stabilize conformance theory data discovery. |
| src/libraries/System.Runtime.Loader/tests/TpaLoadFailureTest.cs | Skips path/fusion-log validation tests on Apple mobile where the assumptions don’t hold. |
| src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs | Expands an ActiveIssue platform mask to include MacCatalyst. |
| src/libraries/System.Net.Sockets/tests/FunctionalTests/NetworkStreamTest.cs | Adds an override to supply MemberType for MemberData on a conformance theory. |
| src/libraries/System.Linq.Expressions/tests/DebuggerTypeProxy/ExpressionDebuggerTypeProxyTests.cs | Gates a reflection-heavy theory away from NativeAOT via ConditionalTheory. |
| src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/Internal/HostTests.cs | Further gates Moq/RefEmit-based tests away from aggressively-trimmed/AOT-like environments. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
This was referenced May 21, 2026
Open
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BrzVlad
reviewed
Jun 12, 2026
… per-override DynamicDependency Address review feedback: rather than adding [MemberData]/[DynamicDependency] overrides on each derived test to root the inherited statics, root the StreamConformanceTests assembly in an ILLink.Descriptors.xml, mirroring System.IO.FileSystem.Tests. Reverts the CryptoStream and NetworkStreamTest overrides. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dotnet-policy-service
Bot
added
the
linkable-framework
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Closed
BrzVlad
approved these changes
Jun 15, 2026
Member
Author
|
/ba-g dotnet/dnceng#1883 |
Closed
github-actions Bot
added a commit
that referenced
this pull request
Jul 2, 2026
TestCustomAttributeDecoderGenericUsingReflection resolves nested enum types by name via Type.GetType in GetUnderlyingEnumType. Under aggressive trimming on maccatalyst (AllSubsets_CoreCLR) those names are stripped, so Type.GetType returns null, no branch matches, and the provider throws ArgumentOutOfRangeException. Add an ILLink trimmer root descriptor that preserves the containing type (and its nested enums) on Apple mobile, mirroring the approach used for StreamConformanceTests in #128409. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On maccatalyst-arm64
AllSubsets_CoreCLR, ILLink strips the inheritedReadWrite_Success_MemberDataandCopyToAsync_AllDataCopied_MemberDatastatics onConnectedStreamConformanceTests, so xUnit's[MemberData]lookup fails forCryptoStreamTests.ReadWrite_SuccessandNetworkStreamTest.CopyToAsync_AllDataCopied. Adds a[DynamicDependency]on each derived override to root the base statics, and restores theIsMultithreadingSupportedguard onCopyToAsync_AllDataCopied.