Skip to content

[QUIC] Remove check for AzL3 for QUIC and H/3 tests#126834

Merged
ManickaP merged 1 commit into
dotnet:mainfrom
ManickaP:azl3-reenable-quic
Apr 24, 2026
Merged

[QUIC] Remove check for AzL3 for QUIC and H/3 tests#126834
ManickaP merged 1 commit into
dotnet:mainfrom
ManickaP:azl3-reenable-quic

Conversation

@ManickaP

Copy link
Copy Markdown
Member

Fixes #123216

SymCrypt 1.9.5 is out, docker images are already fixed, let's see if the base VM images are up-to-date or need re-building.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Azure Linux 3 VM-specific test gating that was added due to MsQuic failures, with the intent of re-enabling QUIC and HTTP/3 test execution now that SymCrypt images are expected to be updated.

Changes:

  • Remove IsNotAzureLinux3VM conditions from System.Net.Quic functional test classes.
  • Remove the IsNotAzureLinux3VM check from HttpClientHandlerTestBase.IsHttp3Supported.
  • Delete the IsNotAzureLinux3VM helper properties that implemented the AzL3 skip logic.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicTestBase.cs Removes the IsNotAzureLinux3VM helper used to skip AzL3 VMs.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs Drops AzL3 from the ConditionalClass gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamConnectedStreamConformanceTests.cs Drops AzL3 from the ConditionalClass gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Drops AzL3 from the ConditionalClass gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs Drops AzL3 from the ConditionalClass gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs Drops AzL3 from the ConditionalClass gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicRemoteExecutorTests.cs Drops AzL3 from the ConditionalClass gating list.
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs Attempts to remove AzL3 gating, but introduces an invalid ConditionalClass usage (see comment).
src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicCipherSuitesPolicyTests.cs Drops AzL3 from the ConditionalClass gating list.
src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTestBase.SocketsHttpHandler.cs Removes the AzL3 gating from HTTP/3 support detection and deletes the helper property.

@ManickaP

Copy link
Copy Markdown
Member Author

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@ManickaP

Copy link
Copy Markdown
Member Author

/azp run runtime

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP

Copy link
Copy Markdown
Member Author

This is still failing, the bare VMs have not been updated yet. I'm asking around in FR channel. I'll keep this opne for now, hopefully it won't take long to get updates in the images.

@wfurt

wfurt commented Apr 16, 2026

Copy link
Copy Markdown
Member

that is curious. The images were rebuilt last week. I don't see Quic failures above.

@ManickaP

Copy link
Copy Markdown
Member Author

that is curious. The images were rebuilt last week. I don't see Quic failures above.

Because we don't normally run our tests on "naked" VM (sometimes we do, but I don't fully understand the heuristics), but outerloop does: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1380018&view=ms.vss-test-web.build-test-results-tab, and it's still failing: https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-126834-merge-2f014b2698b447beb9/System.Net.Quic.Functional.Tests/3/console.8b9de10c.log?helixlogtype=result

And FR are on it, we figured out that it should be rebuilt and packages updated, but somehow they aren't... So it's being investigated.

@ManickaP

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop

@ManickaP

Copy link
Copy Markdown
Member Author

/azp run runtime

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP

Copy link
Copy Markdown
Member Author

It's running now:

Console log: 'System.Net.Quic.Functional.Tests' from job 25aff52c-3400-4111-b153-178f1b7918b6 workitem 7b4f8783-25e9-415d-b4b8-dca71a1aef1b (azurelinux.3.amd64.open.rt) executed on machine a00DVDJ running Linux-6.6.130.1-3.azl3-x86_64-with-glibc2.38
...
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 8 of 153 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on [2 threads], stop on fail = off)
MsQuic supported and using 'libmsquic.so 2.5.7.144496271 (801b0e958f3e33e9998766c3371c1ca348254650)' (OpenSSL).
MsQuic Counters:
    CONN_CREATED 3608
    CONN_HANDSHAKE_FAIL 1231
    CONN_APP_REJECT 1226
    CONN_LOAD_REJECT 0

Unobserved exceptions of 0 different types: 

  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 30, Errors: 0, Failed: 0, Skipped: 0, Time: 54.194s

https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-126834-merge-25aff52c34004111b1/System.Net.Quic.Functional.Tests/1/console.d4105419.log?helixlogtype=result
https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-126834-merge-614d7c181bbf4ece8b/System.Net.Quic.Functional.Tests/1/console.e8ce2d0b.log?helixlogtype=result

@ManickaP

Copy link
Copy Markdown
Member Author

/ba-g unrelated

@ManickaP ManickaP merged commit a5840f3 into dotnet:main Apr 24, 2026
89 of 107 checks passed
@ManickaP ManickaP deleted the azl3-reenable-quic branch May 22, 2026 11:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MsQuic fails with QUIC_STATUS_OUT_OF_MEMORY on AzureLinux

3 participants