Add acquire barrier to populate bit reading#117523
Merged
Merged
Conversation
The setting of the NDirectMethodDesc::kNDirectPopulated bit is done via an interlocked operation. This bit is used to indicate if the NDirectMethodDesc has been populated with the needed information to load the P/Invoke. The reading of this bit however was missing an acquire barrier and thus setting of fields between the check and set weren't being observed correctly.
Contributor
|
Tagging subscribers to this area: @dotnet/interop-contrib |
davidwrighton
approved these changes
Jul 10, 2025
jkoritzinsky
approved these changes
Jul 11, 2025
jkoritzinsky
left a comment
jkoritzinsky
left a comment
Member
There was a problem hiding this comment.
This must have been an absolute pain to debug and find. LGTM!
This was referenced Jul 11, 2025
Member
|
Definitely not for this change, but should we have something similar for |
Member
Author
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17923699227 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setting of the
NDirectMethodDesc::kNDirectPopulatedbit is done via an interlocked operation. This bit is used to indicate if theNDirectMethodDeschas been populated with the needed information to load the P/Invoke. The reading of this bit however was missing an acquire barrier and thus setting of fields between the check and set weren't being observed correctly.Fixes #112565
This should be considered to backport to .NET 9.0.