Fix reporting GC fields from base types#111011
Merged
Merged
Conversation
Fixes dotnet#110836. When we extended managed CorInfoImpl to support object stack allocation in dotnet#104411, there was one more spot that assumed valuetypes only in `GatherClassGCLayout` that we missed. This resulted in not reporting any GC pointers in base types.
ghost
added
the
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Could you please also fix the comment at runtime/src/coreclr/inc/corinfo.h Line 2380 in 6045e29 getHeapClassSize for those.
|
jkotas
approved these changes
Dec 31, 2024
jkotas
left a comment
jkotas
left a comment
Member
There was a problem hiding this comment.
Thank you for coming up with a fix for this!
Member
Author
|
/ba-g timeouts in macos legs after a comment only change (previous run was green) |
Member
|
Backport candidate? |
Member
Author
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12588764932 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110836.
When we extended managed CorInfoImpl to support object stack allocation in #104411, there was one more spot that assumed valuetypes only in
GatherClassGCLayoutthat we missed. This resulted in not reporting any GC pointers in base types.Cc @dotnet/ilc-contrib