Skip to content

Delete UsePublishedCrossgen2 property#108693

Merged
jkotas merged 3 commits into
dotnet:mainfrom
jkotas:UsePublishedCrossgen2
Oct 11, 2024
Merged

Delete UsePublishedCrossgen2 property#108693
jkotas merged 3 commits into
dotnet:mainfrom
jkotas:UsePublishedCrossgen2

Conversation

@jkotas

@jkotas jkotas commented Oct 9, 2024

Copy link
Copy Markdown
Member

It should not be necessary after #107772

@jkotas

jkotas commented Oct 9, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

jkotas commented Oct 10, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas force-pushed the UsePublishedCrossgen2 branch from 6bb9241 to 486ee02 Compare October 10, 2024 03:12
@jkotas

jkotas commented Oct 10, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas force-pushed the UsePublishedCrossgen2 branch from 486ee02 to 9926132 Compare October 10, 2024 07:31
@jkotas

jkotas commented Oct 10, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa ivdiazsa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this Jan! Are these errors related to these changes?

* You intended to execute a .NET program, but dotnet-/__w/1/s/artifacts/bin/coreclr/linux.x64.Release/crossgen2/crossgen2.dll does not exist.

We can merge once we get these ones resolved or confirmed to be unrelated.

@jkotas

jkotas commented Oct 10, 2024

Copy link
Copy Markdown
Member Author

Are these errors related to these changes?

Yes, these errors are related. I need to fix those before this can be merged.

@jkotas

jkotas commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas force-pushed the UsePublishedCrossgen2 branch from 355fc2e to 1d9fb4b Compare October 11, 2024 12:50
@jkotas

jkotas commented Oct 11, 2024

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr crossgen2 outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas jkotas merged commit 10e3d01 into dotnet:main Oct 11, 2024
@jkotas jkotas deleted the UsePublishedCrossgen2 branch October 11, 2024 16:25
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants