JIT: fix permute node type in AVX simd sum#103680
Merged
Merged
Conversation
In `gtNewSimdSumNode` we need to type permute nodes as `simd16`, not the sum's type. If we split the tree at the permute we spill to the wrong typed temp. Also provide the ability to halt stress tree splitting after some number of splits. Fixes dotnet#102335.
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
@tannergooding PTAL |
tannergooding
approved these changes
Jun 19, 2024
Member
Author
|
/azp run runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 19, 2024
Open
Member
Author
|
Remaining jit stress failures look unrelated (9 in all, about half are timeouts). One leg still to run. |
Member
Author
|
Looks like the pending x86 jitstress run was cancelled. Going to merge nonetheless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
gtNewSimdSumNodewe need to type permute nodes assimd16, not the sum's type. If we split the tree at the permute we spill to the wrong typed temp.Also provide the ability to halt stress tree splitting after some number of splits.
Fixes #102335.