match IPv4MappedToIPv6 address in IPv4 networks#103381
Merged
Merged
Conversation
MihuBot
approved these changes
Jun 12, 2024
MihuBot
left a comment
MihuBot
left a comment
There was a problem hiding this comment.
Thanks.
I agree this should be the more common direction (IPv4 IPNetwork + DualMode addresses to test).
antonfirsov
reviewed
Jun 12, 2024
antonfirsov
approved these changes
Jun 12, 2024
This was referenced Jun 13, 2024
This was referenced Jun 15, 2024
This was referenced Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #98427.
This change does exactly what #98427 asked for. e.g. if there IPv4
IPNetworkPv4-Mapped IPv6 Addresses address would function same as it's IPv4 equivalent. This prevents hassle and allocations fromIPAddress.MapToIPv4one would have to use.Note that this is not symmetric. e.g. if somebody would create
IPNetworkwith::ffff:192.168.0.0/24IPv4 address would not match that at the moment. We can fix that if we want to @MihaZupan and @antonfirsov. But I;'m not sure if there is compelling use case. (I can see one for the address from DualMode Socket)