[HTTP/3] Wrap Cancelled Request with OCE instead of QuicException#103081
Merged
Conversation
…owing QuicException as Inner
ghost
added
the
Member
Author
|
/azp list |
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liveans
commented
Jun 5, 2024
rzikm
approved these changes
Jun 6, 2024
rzikm
left a comment
rzikm
left a comment
Member
There was a problem hiding this comment.
LGTM, modulo the one open comment.
ManickaP
reviewed
Jun 12, 2024
This was referenced Jun 12, 2024
ManickaP
approved these changes
Jun 17, 2024
ManickaP
left a comment
ManickaP
left a comment
Member
There was a problem hiding this comment.
LGTM, just please add some comments to your new cases similar to the comments in cases above in their respective methods.
This was referenced Jun 17, 2024
Member
Author
|
/ba-g failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98220